From: Rob Herring <robh+dt@kernel.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: krzysztof.kozlowski+dt@linaro.org, kys@microsoft.com,
haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
daniel.lezcano@linaro.org, tglx@linutronix.de,
virtualization@lists.linux-foundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, mikelley@microsoft.com,
dphadke@linux.microsoft.com
Subject: Re: [PATCH v5 2/5] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported
Date: Thu, 9 Feb 2023 09:17:45 -0600 [thread overview]
Message-ID: <CAL_JsqJisFuagtm_VyzTiMzRiB18z+ZX8j63+efTDLWNaccoOQ@mail.gmail.com> (raw)
In-Reply-To: <1675944939-22631-3-git-send-email-ssengar@linux.microsoft.com>
On Thu, Feb 9, 2023 at 6:15 AM Saurabh Sengar
<ssengar@linux.microsoft.com> wrote:
>
> acpi_sleep_state_supported() currently is defined only when
> CONFIG_ACPI=y. For future work to enable device tree builds, put this
> function under #ifdef CONFIG_ACPI. Otherwise, return 'false' from
> hv_is_hibernation_supported() as Hyper-V guest configs using device
> tree don't support hibernation.
>
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> ---
> drivers/hv/hv_common.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index 52a6f89ccdbd..370ec20d1993 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -234,7 +234,11 @@ EXPORT_SYMBOL_GPL(hv_setup_dma_ops);
>
> bool hv_is_hibernation_supported(void)
> {
> +#ifdef CONFIG_ACPI
> return !hv_root_partition && acpi_sleep_state_supported(ACPI_STATE_S4);
Rework the acpi_bus.h header so that this is defined for !CONFIG_ACPI:
static inline bool acpi_sleep_state_supported(u8 sleep_state) { return false; }
Then you don't need this change here. That or using IS_ENABLED() is
strongly preferred over #ifdefs.
Rob
next prev parent reply other threads:[~2023-02-09 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 12:15 [PATCH v5 0/5] Device tree support for Hyper-V VMBus driver Saurabh Sengar
2023-02-09 12:15 ` [PATCH v5 1/5] drivers/clocksource/hyper-v: non ACPI support in hyperv clock Saurabh Sengar
2023-02-09 12:15 ` [PATCH v5 2/5] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Saurabh Sengar
2023-02-09 15:17 ` Rob Herring [this message]
2023-02-09 17:29 ` Saurabh Singh Sengar
2023-02-09 12:15 ` [PATCH v5 3/5] Drivers: hv: vmbus: Convert acpi_device to more generic platform_device Saurabh Sengar
2023-02-09 12:15 ` [PATCH v5 4/5] dt-bindings: hypervisor: VMBus Saurabh Sengar
2023-02-09 12:15 ` [PATCH v5 5/5] Driver: VMBus: Add device tree support Saurabh Sengar
2023-02-09 15:50 ` Rob Herring
2023-02-09 17:46 ` Saurabh Singh Sengar
2023-02-10 22:37 ` Rob Herring
2023-02-13 11:24 ` Saurabh Singh Sengar
2023-02-17 13:27 ` Saurabh Singh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJisFuagtm_VyzTiMzRiB18z+ZX8j63+efTDLWNaccoOQ@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=dphadke@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).