From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE9D3191B8 for ; Mon, 24 Nov 2025 17:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764003719; cv=none; b=OqdKqYyi7aAyPpHKCyxVz9Q77hK49ty8EXjAL7dXrsUd0eh8gtdJVDfYDFh5Ybq1ClIC3mvOkGXF2lIAcLGQ/H8CUnmJX0SqliLXLKm0ascC244X//k4SQHtA78yALjM6bjILW8j1D7D48eUiU61VGObr96HJsU8MFU/BprcvP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764003719; c=relaxed/simple; bh=94qwcdvISJhCCZRqsIa3gf9UsdjE7+PgQuqqXXX1d/I=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AVeGM/kOZT01XDRXaSSDDoaiqS5TVPZSgl/6i29xeQz4E5Ohid+5Enm9yEKWEnVyOk0Pv4did7lroK8dcS/cNAuhheDJcnQkokQzoPC1nciZRQL//3WUUjjsXfIQ1WqtANwcmwvOvWEKnnTR/8+gndDxRlUT5C44E73STMAcSLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZX/x+hJS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZX/x+hJS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DC3AC19424 for ; Mon, 24 Nov 2025 17:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764003719; bh=94qwcdvISJhCCZRqsIa3gf9UsdjE7+PgQuqqXXX1d/I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZX/x+hJSP1P0qZ14NE/Hpp1YeMGnHI6Dx+de22oXXzeIPeuZi0tl3P1Qd24pJ0XE0 DRNM1Dd3316lM7xNS7AWRIbFzclkw4gDqqL81VhAQaFzCrk5BozfWNdzxmbc6fYQp8 kn+0NKGkHFOhHeoMv5L1ngwbgDUnIbUbp6tlKYGmdxP0m4yYg2MKsoyZorJ2kn4WTZ F3bqZjMbyD92+f9gsI095j+0fWID4ZYBYGTJ/rjgAnorVZQK8kiUv1QveAEvgnUYOf huarqKe2o9quMSVImjx1vZr1QC0jRU0EDKbJpUcFokzIjnKe/JftNOKKvSdJKtX3Z6 h8Bt3/5SbF7cw== Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-641977dc00fso6436713a12.1 for ; Mon, 24 Nov 2025 09:01:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXAIQjOHAYhQhekvUovvd+s2iePu1N4Janr6Ri6s2JE6QmTBxg8omPZhMav2XexfEJcmoBGAvkRFHBz@vger.kernel.org X-Gm-Message-State: AOJu0YyMWN0SqY8aEqj4sYFUpstov4+jMHqVytXojKYRboUtp34bnA1B 40ZvELAbj3JL5ihO34guagdLDoM64L/O/ez4lIYcQYIJaKPkTwVpD5+rTbHi/xi1a0sAavGRLrF 55uP6za/6bclGWxqCDTOKapQKwtS17A== X-Google-Smtp-Source: AGHT+IFXf67K5MLIAp6akzlHdfYGJk0vOgsjBiRm9AVrjqIUmIUGdpSyKqEED/1RG1dv63/7cyPADsAtAzCIEsIc398= X-Received: by 2002:a17:907:724c:b0:b71:cec2:d54 with SMTP id a640c23a62f3a-b767183f903mr1306003666b.57.1764003716998; Mon, 24 Nov 2025 09:01:56 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-2-herve.codina@bootlin.com> <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> In-Reply-To: <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> From: Rob Herring Date: Mon, 24 Nov 2025 11:01:45 -0600 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_bmkdBVVKkq4S-uwQ2SqCH_pnOkbmYTHFkvDFxh_4sc4_x1p8K7UCt8Q0zg Message-ID: Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" To: Kalle Niemi Cc: Herve Codina , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Geert Uytterhoeven , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni , mazziesaccount@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 24, 2025 at 10:44=E2=80=AFAM Kalle Niemi = wrote: > > > On 11/24/25 16:53, Rob Herring wrote: > > On Mon, Nov 24, 2025 at 8:48=E2=80=AFAM Kalle Niemi wrote: > >> On 10/15/25 10:13, Herve Codina wrote: > >>> From: Saravana Kannan > >>> > >>> This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. > >>> > >>> While the commit fixed fw_devlink overlay handling for one case, it > >>> broke it for another case. So revert it and redo the fix in a separat= e > >>> patch. > >>> > >>> Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT overlays= ") > >>> Reported-by: Herve Codina > >>> Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJ= gyo8x6=3D9F9rZ+-KzjOg@mail.gmail.com/ > >>> Closes: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.c= om/ > >>> Closes: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.= com/ > >>> Signed-off-by: Saravana Kannan > >>> Link: https://lore.kernel.org/lkml/20240411235623.1260061-2-saravanak= @google.com/ > >>> Signed-off-by: Herve Codina > >>> Acked-by: Mark Brown > >>> --- > >>> drivers/bus/imx-weim.c | 6 ------ > >>> drivers/i2c/i2c-core-of.c | 5 ----- > >>> drivers/of/dynamic.c | 1 - > >>> drivers/of/platform.c | 5 ----- > >>> drivers/spi/spi.c | 5 ----- > >>> 5 files changed, 22 deletions(-) > >>> > >>> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > >>> index 83d623d97f5f..87070155b057 100644 > >>> --- a/drivers/bus/imx-weim.c > >>> +++ b/drivers/bus/imx-weim.c > >>> @@ -327,12 +327,6 @@ static int of_weim_notify(struct notifier_block = *nb, unsigned long action, > >>> "Failed to setup timing for '%pOF'\n"= , rd->dn); > >>> > >>> if (!of_node_check_flag(rd->dn, OF_POPULATED)) { > >>> - /* > >>> - * Clear the flag before adding the device so t= hat > >>> - * fw_devlink doesn't skip adding consumers to = this > >>> - * device. > >>> - */ > >>> - rd->dn->fwnode.flags &=3D ~FWNODE_FLAG_NOT_DEVI= CE; > >>> if (!of_platform_device_create(rd->dn, NULL, &= pdev->dev)) { > >>> dev_err(&pdev->dev, > >>> "Failed to create child device= '%pOF'\n", > >>> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c > >>> index eb7fb202355f..30b48a428c0b 100644 > >>> --- a/drivers/i2c/i2c-core-of.c > >>> +++ b/drivers/i2c/i2c-core-of.c > >>> @@ -176,11 +176,6 @@ static int of_i2c_notify(struct notifier_block *= nb, unsigned long action, > >>> return NOTIFY_OK; > >>> } > >>> > >>> - /* > >>> - * Clear the flag before adding the device so that fw_d= evlink > >>> - * doesn't skip adding consumers to this device. > >>> - */ > >>> - rd->dn->fwnode.flags &=3D ~FWNODE_FLAG_NOT_DEVICE; > >>> client =3D of_i2c_register_device(adap, rd->dn); > >>> if (IS_ERR(client)) { > >>> dev_err(&adap->dev, "failed to create client f= or '%pOF'\n", > >>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > >>> index 2eaaddcb0ec4..b5be7484fb36 100644 > >>> --- a/drivers/of/dynamic.c > >>> +++ b/drivers/of/dynamic.c > >>> @@ -225,7 +225,6 @@ static void __of_attach_node(struct device_node *= np) > >>> np->sibling =3D np->parent->child; > >>> np->parent->child =3D np; > >>> of_node_clear_flag(np, OF_DETACHED); > >>> - np->fwnode.flags |=3D FWNODE_FLAG_NOT_DEVICE; > >>> > >>> raw_spin_unlock_irqrestore(&devtree_lock, flags); > >>> > >>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c > >>> index f77cb19973a5..ef9445ba168b 100644 > >>> --- a/drivers/of/platform.c > >>> +++ b/drivers/of/platform.c > >>> @@ -739,11 +739,6 @@ static int of_platform_notify(struct notifier_bl= ock *nb, > >>> if (of_node_check_flag(rd->dn, OF_POPULATED)) > >>> return NOTIFY_OK; > >>> > >>> - /* > >>> - * Clear the flag before adding the device so that fw_d= evlink > >>> - * doesn't skip adding consumers to this device. > >>> - */ > >>> - rd->dn->fwnode.flags &=3D ~FWNODE_FLAG_NOT_DEVICE; > >>> /* pdev_parent may be NULL when no bus platform device= */ > >>> pdev_parent =3D of_find_device_by_node(parent); > >>> pdev =3D of_platform_device_create(rd->dn, NULL, > >>> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > >>> index 2e0647a06890..b22944a207c9 100644 > >>> --- a/drivers/spi/spi.c > >>> +++ b/drivers/spi/spi.c > >>> @@ -4791,11 +4791,6 @@ static int of_spi_notify(struct notifier_block= *nb, unsigned long action, > >>> return NOTIFY_OK; > >>> } > >>> > >>> - /* > >>> - * Clear the flag before adding the device so that fw_d= evlink > >>> - * doesn't skip adding consumers to this device. > >>> - */ > >>> - rd->dn->fwnode.flags &=3D ~FWNODE_FLAG_NOT_DEVICE; > >>> spi =3D of_register_spi_device(ctlr, rd->dn); > >>> put_device(&ctlr->dev); > >>> > >> Sorry, some of you will receive this message now for second time. Firs= t > >> message was sent to older series of patches. > >> - > >> > >> Hello, > >> > >> Test system testing drivers for ROHM ICs bisected this commit to cause > >> BD71847 drivers probe to not be called. > > This driver (and overlay support) is in linux-next or something out of > > tree on top of linux-next? > > > > Rob > > Yes the driver is in mainline linux: /drivers/mfd/rohm-bd718x7.c I don't see any support to apply overlays in that driver. Rob