devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>, Yang-Leo Li <leoyang.li@nxp.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	a.tropschug@ebs-systart.com, m.bittner@ebs-systart.com,
	Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis
Date: Mon, 14 Jan 2019 12:02:47 -0600	[thread overview]
Message-ID: <CAL_JsqJpRPrCpRTpqh1v6JZwpEtZnaeuLTHR+0EiMSoxbk9zeQ@mail.gmail.com> (raw)
In-Reply-To: <20190114102053.16013-3-manivannan.sadhasivam@linaro.org>

On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> Add devicetree binding for Oxalis board in JSON format. While adding
> that, let's fix the description for LS1012A also.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index d34fe0749199..0f30142fe316 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -173,12 +173,13 @@ properties:
>                - fsl,vf610
>                - fsl,vf610m4
>
> -      - description: LS1021A based Boards
> +      - description: LS1012A based Boards

Well, yes that was wrong...

>          items:
>            - enum:
>                - fsl,ls1012a-rdb
>                - fsl,ls1012a-frdm
>                - fsl,ls1012a-qds
> +              - ebs-systart,oxalis

Sort alphabetically.

>            - const: fsl,ls1021a

And this is wrong too.

I you just change it, then we will be missing an entry for LS1021A.
What's the status of that SoC because there is no board dts file? We
should not have .dtsi files in the kernel which don't get built.

Rob

  reply	other threads:[~2019-01-14 18:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 10:20 [PATCH v2 0/3] Add Oxalis board support Manivannan Sadhasivam
2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam
2019-01-16 21:10   ` Rob Herring
2019-01-14 10:20 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Manivannan Sadhasivam
2019-01-14 18:02   ` Rob Herring [this message]
2019-01-14 18:10     ` Manivannan Sadhasivam
2019-01-16  2:21     ` Shawn Guo
2019-01-16  4:07       ` Rob Herring
2019-01-16 10:14         ` Shawn Guo
2019-01-21  6:09           ` Manivannan Sadhasivam
2019-01-21 19:57             ` Leo Li
2019-01-22  3:00               ` Shawn Guo
2019-01-14 10:20 ` [PATCH v2 3/3] arm64: dts: freescale: Add devicetree " Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJpRPrCpRTpqh1v6JZwpEtZnaeuLTHR+0EiMSoxbk9zeQ@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=a.tropschug@ebs-systart.com \
    --cc=amit.kucheria@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.bittner@ebs-systart.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).