From: Rob Herring <robh@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sean Young <sean@mess.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Timo Kokkonen <timo.t.kokkonen@iki.fi>
Subject: Re: [PATCH 4/4] [media] rc: pwm-ir-tx: add new driver
Date: Mon, 10 Jul 2017 10:12:25 -0500 [thread overview]
Message-ID: <CAL_JsqJxiGh2A1ApLA364vo5CJGkW+r7mrXPcZBGZ1KuXi4HHw@mail.gmail.com> (raw)
In-Reply-To: <20170707161524.GA11857@amd>
On Fri, Jul 7, 2017 at 11:15 AM, Pavel Machek <pavel@ucw.cz> wrote:
> On Fri 2017-07-07 08:59:28, Rob Herring wrote:
>> On Sun, Jul 02, 2017 at 12:06:13PM +0100, Sean Young wrote:
>> > This is new driver which uses pwm, so it is more power-efficient
>> > than the bit banging gpio-ir-tx driver.
>> >
>> > Signed-off-by: Sean Young <sean@mess.org>
>> > ---
>> > .../devicetree/bindings/leds/irled/pwm-ir-tx.txt | 13 ++
>>
>> Please make this a separate patch.
>
> Come on... The driver is trivial, and you even quoted the binding
> below. Saying "Acked-by:" would not have been that much additional
> work...
True, and I don't always ask for it especially when there is no other
comment. However, the gpio-ir-tx patch needs other changes anyway.
Rob
prev parent reply other threads:[~2017-07-10 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1498992850.git.sean@mess.org>
2017-07-02 11:06 ` [PATCH 3/4] [media] rc: gpio-ir-tx: add new driver Sean Young
2017-07-07 13:58 ` Rob Herring
2017-07-02 11:06 ` [PATCH 4/4] [media] rc: pwm-ir-tx: " Sean Young
[not found] ` <88fa0219db3388fad7bcc7b20cf30dd41e763aee.1498992850.git.sean-hENCXIMQXOg@public.gmane.org>
2017-07-04 12:58 ` Sean Young
2017-07-07 13:59 ` Rob Herring
2017-07-07 16:15 ` Pavel Machek
2017-07-10 15:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJxiGh2A1ApLA364vo5CJGkW+r7mrXPcZBGZ1KuXi4HHw@mail.gmail.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sean@mess.org \
--cc=timo.t.kokkonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).