From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 4/4] [media] rc: pwm-ir-tx: add new driver Date: Mon, 10 Jul 2017 10:12:25 -0500 Message-ID: References: <88fa0219db3388fad7bcc7b20cf30dd41e763aee.1498992850.git.sean@mess.org> <20170707135928.6cs6vx7z6lj3birp@rob-hp-laptop> <20170707161524.GA11857@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170707161524.GA11857@amd> Sender: linux-media-owner@vger.kernel.org To: Pavel Machek Cc: Sean Young , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , Ivaylo Dimitrov , Timo Kokkonen List-Id: devicetree@vger.kernel.org On Fri, Jul 7, 2017 at 11:15 AM, Pavel Machek wrote: > On Fri 2017-07-07 08:59:28, Rob Herring wrote: >> On Sun, Jul 02, 2017 at 12:06:13PM +0100, Sean Young wrote: >> > This is new driver which uses pwm, so it is more power-efficient >> > than the bit banging gpio-ir-tx driver. >> > >> > Signed-off-by: Sean Young >> > --- >> > .../devicetree/bindings/leds/irled/pwm-ir-tx.txt | 13 ++ >> >> Please make this a separate patch. > > Come on... The driver is trivial, and you even quoted the binding > below. Saying "Acked-by:" would not have been that much additional > work... True, and I don't always ask for it especially when there is no other comment. However, the gpio-ir-tx patch needs other changes anyway. Rob