From: Rob Herring <robh@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: Restrict protocol child node properties
Date: Mon, 6 Feb 2023 11:22:38 -0600 [thread overview]
Message-ID: <CAL_JsqK9dzohSW_035Y8F2DRMZLjmwd-Hq=c2sqM95ofWRTj8w@mail.gmail.com> (raw)
In-Reply-To: <20230206104704.xe72srqygepguuk2@bogus>
On Mon, Feb 6, 2023 at 4:47 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Hi Rob,
>
> On Fri, Jan 27, 2023 at 12:52:33PM -0600, Rob Herring wrote:
> >
> > TBC, 'protocol@.*' would not allow anything but the properties defined
> > in the /$defs/protocol-node. So [1] would throw errors without a
> > schema addition.
>
> Right I clearly missed that, somehow I assumed it would allow.
>
> > We should either do that along with dropping 'protocol@18' or we keep
> > protocol 0x18 node and add all other providerless protocols. I don't
> > think we need the latter to just check unit-address vs. reg.
>
> I only argument today it to allow protocol specific transport. So we could
> delay addition of it until someone needs that way. So far we haven't seen
> anyone using it other than performance(even that is not needed with the
> introduction of fast channels that are auto discoverable in relatively
> newer versions of the spec).
I failed to think about 'protocol@.*' would match on every protocol,
so we have to list them explicitly: '^protocol@(18|xx|yy|zz)$'
Anyways, I think the conclusion is the patch should stay as-is and so
I've applied it.
Rob
prev parent reply other threads:[~2023-02-06 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 22:20 [PATCH] dt-bindings: firmware: arm,scmi: Restrict protocol child node properties Rob Herring
2023-01-25 12:42 ` Sudeep Holla
2023-01-25 13:43 ` Cristian Marussi
2023-01-25 14:11 ` Sudeep Holla
2023-01-25 15:40 ` Cristian Marussi
2023-01-25 17:30 ` Rob Herring
2023-01-26 9:43 ` Cristian Marussi
2023-01-26 14:46 ` Sudeep Holla
2023-01-26 15:25 ` Rob Herring
2023-01-26 17:04 ` Sudeep Holla
2023-01-27 18:52 ` Rob Herring
2023-02-06 10:47 ` Sudeep Holla
2023-02-06 17:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqK9dzohSW_035Y8F2DRMZLjmwd-Hq=c2sqM95ofWRTj8w@mail.gmail.com' \
--to=robh@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).