Re: [PATCH 1/2] ARM: dt-binding: fix GIC example

[Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Fri, Apr 11, 2014 at 8:23 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring:
>> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> > Hi Rob,
>> >
>> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring:
>> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> >> > From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>> >> >
>> >> > When using interrupt-maps, the size of a map entry is #address-cells +
>> >>
>> >> Plus what? You mean ", and "?
>> >>
>> > Urgh, I obviously messed this up while editing the commit message in the
>> > last minute. It should have been something along the lines of:
>> >
>> > When using interrupt-maps, the size of a map entry is #address-cells +
>> > #interrupt-cells. address-cells should be 0 as this offset is not used
>> > in the GIC.
>> >
>> > As #address-cells = <0> is the same as not specifying the
>> > property, simply remove it.
>> >
>> > Can you edit this while applying, or should I send a new patch?
>>
>> I'll fix it up and apply.
>>
> Thanks.
>
>> >
>> >> > address-cells should be 0 as this is not used.
>> >> >
>> >> > As #address-cells = <0> is the same as not specifying the
>> >> > property, simply remove it.
>> >> >
>> >> > Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
>> >> > Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> >>
>> >> Did this get applied? I can't seem to find patch 2.
>> >>
>> > As Shawn pointed out patch 2 got applied through the imx tree as it
>> > fixes a real bug there.
>>
>> It was highlighted that other instances beyond iMX were wrong. Please
>> fix those as well.
>
> Oh, I wasn't aware of that. Will send patches.

It was raised here: http://www.spinics.net/lists/linux-pci/msg29768.html

Here's a somewhat accurate list:

$ git grep -A8 'arm,.*gic' origin/master  -- arch/arm/boot/dts | grep
'address.*1'
origin/master:arch/arm/boot/dts/ecx-2000.dts-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/highbank.dts-
#address-cells = <1>;
origin/master:arch/arm/boot/dts/imx6qdl.dtsi-           #address-cells = <1>;
origin/master:arch/arm/boot/dts/imx6sl.dtsi-            #address-cells = <1>;
origin/master:arch/arm/boot/dts/keystone.dtsi-          #address-cells = <1>;
origin/master:arch/arm/boot/dts/r8a7740.dtsi-           #address-cells = <1>;
origin/master:arch/arm/boot/dts/sh73a0.dtsi-            #address-cells = <1>;
origin/master:arch/arm/boot/dts/socfpga.dtsi-           #address-cells = <1>;
origin/master:arch/arm/boot/dts/ste-dbx5x0.dtsi-
 #address-cells = <1>;
origin/master:arch/arm/boot/dts/vf610.dtsi-
 #address-cells = <1>;
origin/master:arch/arm/boot/dts/zynq-7000.dtsi-
#address-cells = <1>;

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html