From: Rob Herring <robh@kernel.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Collabora Kernel ML <kernel@collabora.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Simon Glass <sjg@chromium.org>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: input: convert cros-ec-keyb to json-schema
Date: Fri, 9 Oct 2020 08:23:24 -0500 [thread overview]
Message-ID: <CAL_JsqKCuajndKPXNKJZ2DGkoTrB2-EDMH6pKHN3ipduso9SzQ@mail.gmail.com> (raw)
In-Reply-To: <20201009052829.a4jvxi5tqhljovki@rcn-XPS-13-9360>
On Fri, Oct 9, 2020 at 12:28 AM Ricardo Cañuelo
<ricardo.canuelo@collabora.com> wrote:
>
> Hi Rob,
>
> Thanks for reviewing the patch
>
> On jue 08-10-2020 13:32:41, Rob Herring wrote:
> > These already have a type and description, don't repeat it here.
> >
> > If no other constraints, then just 'linux,keymap: true'. Or you can use
> > unevaluatedProperties instead of additionalProperties. The former will
> > take the $ref to matrix-keymap.yaml into account.
>
> That's what I did in v1, using input/imx-keypad.yaml as an example along
> with the comment in example-schema.yaml about unevaluatedProperties, but
> then I also saw you mention in other threads that support for
> unevaluatedProperties is not implemented yet and that documenting the
> additional properties/nodes is preferred (that's what I understood, at
> least):
>
> https://lore.kernel.org/dri-devel/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
>
> Was it right in v1 then?
Yes. There is some value in explicitly listing the properties here if
only a subset of them are valid for this binding, but that's not the
case here.
Rob
next prev parent reply other threads:[~2020-10-09 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 10:28 [PATCH v2 0/3] Fix checker warnings related to cros-ec binding Ricardo Cañuelo
2020-10-08 10:28 ` [PATCH v2 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema Ricardo Cañuelo
2020-10-11 11:17 ` Enric Balletbo i Serra
2020-10-08 10:28 ` [PATCH v2 2/3] dt-bindings: input: convert cros-ec-keyb " Ricardo Cañuelo
2020-10-08 18:32 ` Rob Herring
2020-10-09 5:28 ` Ricardo Cañuelo
2020-10-09 13:23 ` Rob Herring [this message]
2020-10-08 10:28 ` [PATCH v2 3/3] mfd: google,cros-ec: add missing properties Ricardo Cañuelo
2020-10-08 18:38 ` Rob Herring
2020-10-09 5:48 ` Ricardo Cañuelo
2020-10-09 13:34 ` Rob Herring
2020-10-13 6:46 ` Ricardo Cañuelo
2020-10-14 2:18 ` Tzung-Bi Shih
2020-10-15 6:52 ` Ricardo Cañuelo
2020-10-15 8:25 ` Enric Balletbo i Serra
2020-10-15 9:50 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKCuajndKPXNKJZ2DGkoTrB2-EDMH6pKHN3ipduso9SzQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kernel@collabora.com \
--cc=ricardo.canuelo@collabora.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).