From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E71C433DF for ; Fri, 9 Oct 2020 13:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE4AA222BA for ; Fri, 9 Oct 2020 13:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602249817; bh=BJ4ArbfGE3EokdoUX4QCkAYrvzosIdnQOI6oSkddPjI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=MtSE+tla9XbfKvXPFW3fENmD0/wkFKpxHimBDgIEfJtV1eu7cgxsroGmDQhWxq7bh 5DecFPZi+E+BSq0Xuwq9ziQ4j+KljLtpaKrOzmRM++EX3Js4bOcxr+i6qRtda2Ahjl xza0iOcKDPRYtlx+5FkaI/PMW7UOiwLenBGSQr8s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388291AbgJINXh (ORCPT ); Fri, 9 Oct 2020 09:23:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:33582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729935AbgJINXg (ORCPT ); Fri, 9 Oct 2020 09:23:36 -0400 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E59A222BA for ; Fri, 9 Oct 2020 13:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602249816; bh=BJ4ArbfGE3EokdoUX4QCkAYrvzosIdnQOI6oSkddPjI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KOshIkXEs2u9p0F5FWA1Q+9igF9tEBW80eNRrnZGx8w+1s3TlZut3eWEYF/JICHRm 6ztVcrjEly/A/RfVVMflWUUf4h4EnAVjz3891P09YUMCbP6I5sXxhVTuOvyVaLhnKX lsfmQQP/lKhHs6hKnGX4Rrv/fCc+aS6gLnqEcocw= Received: by mail-ot1-f54.google.com with SMTP id i12so8984841ota.5 for ; Fri, 09 Oct 2020 06:23:36 -0700 (PDT) X-Gm-Message-State: AOAM531wxRT0RXEDMnztQLwXd0QNqsHa2OhHfhiUXgHYPLC9bO54rmU6 z4QoU1DR9As34Ppyv9HyY9rxyGZYY0wJ7dXPUQ== X-Google-Smtp-Source: ABdhPJxWH/qIwxKp4DOpjOIfsd3AMueMT5LumqQjxRw0TzGJ3sWVM1KGiT/iyFKjY60xD4qDRhRc0NsY4rodXZB/Q7o= X-Received: by 2002:a9d:5e14:: with SMTP id d20mr281855oti.107.1602249815183; Fri, 09 Oct 2020 06:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20201008102825.3812-1-ricardo.canuelo@collabora.com> <20201008102825.3812-3-ricardo.canuelo@collabora.com> <20201008183241.GA2395464@bogus> <20201009052829.a4jvxi5tqhljovki@rcn-XPS-13-9360> In-Reply-To: <20201009052829.a4jvxi5tqhljovki@rcn-XPS-13-9360> From: Rob Herring Date: Fri, 9 Oct 2020 08:23:24 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] dt-bindings: input: convert cros-ec-keyb to json-schema To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= Cc: Collabora Kernel ML , Enric Balletbo i Serra , Benson Leung , Guenter Roeck , Simon Glass , Doug Anderson , devicetree@vger.kernel.org, Dmitry Torokhov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 9, 2020 at 12:28 AM Ricardo Ca=C3=B1uelo wrote: > > Hi Rob, > > Thanks for reviewing the patch > > On jue 08-10-2020 13:32:41, Rob Herring wrote: > > These already have a type and description, don't repeat it here. > > > > If no other constraints, then just 'linux,keymap: true'. Or you can use > > unevaluatedProperties instead of additionalProperties. The former will > > take the $ref to matrix-keymap.yaml into account. > > That's what I did in v1, using input/imx-keypad.yaml as an example along > with the comment in example-schema.yaml about unevaluatedProperties, but > then I also saw you mention in other threads that support for > unevaluatedProperties is not implemented yet and that documenting the > additional properties/nodes is preferred (that's what I understood, at > least): > > https://lore.kernel.org/dri-devel/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mv= QR-WKRnknQVtGGxQ@mail.gmail.com/ > > Was it right in v1 then? Yes. There is some value in explicitly listing the properties here if only a subset of them are valid for this binding, but that's not the case here. Rob