From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] arm64: dts: hi3660: improve pmu description Date: Wed, 8 Nov 2017 09:55:18 -0600 Message-ID: References: <1510131578-84235-1-git-send-email-xuyiping@hisilicon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1510131578-84235-1-git-send-email-xuyiping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Xu YiPing Cc: Wei Xu , Mark Rutland , Catalin Marinas , Will Deacon , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Nov 8, 2017 at 2:59 AM, Xu YiPing wrote: > cortex a73 pmu is supported, use it instead of armpmu-v3 The subject is misleading and you need a better commit message. Why is this change needed? You are going from 1 to 2 devices. Missing your S-o-B, too. > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > index 13ae69f..f638897 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > @@ -203,21 +203,25 @@ > IRQ_TYPE_LEVEL_HIGH)>; > }; > > - pmu { > - compatible = "arm,armv8-pmuv3"; > + pmu_a53 { Don't use '_' in node names. Building with W=2 will tell you this. > + compatible = "arm,cortex-a53-pmu"; > interrupts = , > , > , > - , > - , > - , > - , > - ; > + ; > interrupt-affinity = <&cpu0>, > <&cpu1>, > <&cpu2>, > - <&cpu3>, > - <&cpu4>, > + <&cpu3>; > + }; > + > + pmu_a73 { > + compatible = "arm,cortex-a73-pmu"; > + interrupts = , > + , > + , > + ; > + interrupt-affinity = <&cpu4>, > <&cpu5>, > <&cpu6>, > <&cpu7>; > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html