From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4] kbuild: Add support for DT binding schema checks Date: Mon, 28 Jan 2019 09:34:47 -0600 Message-ID: References: <20181211202406.27721-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Masahiro Yamada , Sean Hudson , Frank Rowand , Linux ARM , linuxppc-dev , Grant Likely , Kumar Gala , arm-soc , Jonathan Corbet , Mark Rutland , Michal Marek , "open list:DOCUMENTATION" , linux-kbuild List-Id: devicetree@vger.kernel.org On Mon, Jan 28, 2019 at 3:43 AM Geert Uytterhoeven wrote: > > Hi Rob, > > On Tue, Dec 11, 2018 at 9:24 PM Rob Herring wrote: > > This adds the build infrastructure for checking DT binding schema > > documents and validating dts files using the binding schema. > > > > Check DT binding schema documents: > > make dt_binding_check > > > > Build dts files and check using DT binding schema: > > make dtbs_check > > > > Optionally, DT_SCHEMA_FILES can be passed in with a schema file(s) to > > use for validation. This makes it easier to find and fix errors > > generated by a specific schema. > > > > Currently, the validation targets are separate from a normal build to > > avoid a hard dependency on the external DT schema project and because > > there are lots of warnings generated. > > > > Cc: Jonathan Corbet > > Cc: Mark Rutland > > Cc: Masahiro Yamada > > Cc: Michal Marek > > Cc: linux-doc@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-kbuild@vger.kernel.org > > Signed-off-by: Rob Herring > > BTW, what are the CONFIG dependencies for this to work? > E.g. defconfig on x86_64 fails, even after enabling CONFIG_OF: I generally use allmodconfig which enables building all DTs. Yes, there's a dependency on CONFIG_DTC which isn't always enabled with CONFIG_OF. Maybe it should be. The only other solutions I've thought of are either always build dtc or make the targets conditional on CONFIG_DTC. The latter would only change the error message. Rob