From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CDE0C3F6B0 for ; Thu, 28 Jul 2022 21:50:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbiG1Vun (ORCPT ); Thu, 28 Jul 2022 17:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230332AbiG1Vul (ORCPT ); Thu, 28 Jul 2022 17:50:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24DF01F629; Thu, 28 Jul 2022 14:50:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 903A361AC7; Thu, 28 Jul 2022 21:50:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1600C433D6; Thu, 28 Jul 2022 21:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659045040; bh=TIOCNvw+17eRmNBfMFABH6VkBMWnuv6D1qn6yCQMJrw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YBHZYgsKrAuDGDNxgcUIVjuVNislrbcEKsfe/xHrKkvXsKbsnBm0l7C12G3Oa27q8 PlIDnNyVuOSJwbT5Tji2DrzAkwZrc7HNnhNGn3hnDQppcEIXDFS18u0aW3hlVT4faS BixsHF3y5wiguEnyPr1Qjeqob4YsQfoQoYjcA2YwSE8Sfoo06FHJFVTEi068Uyen5r ziANQly7ihmRuTQObzk0XUjy4fvNHaykq0bFtfMvNNtVcLhN69mrWl30UFI35gbBpY ObP2ygENYWaoQHDMCJyzZisRqkcfs++QU6Eod7c+qpNHrwaLu8Ia2lE3tqMKI4vDs3 PF1oFXvnSirvw== Received: by mail-vk1-f178.google.com with SMTP id b2so1445361vkg.2; Thu, 28 Jul 2022 14:50:39 -0700 (PDT) X-Gm-Message-State: AJIora8ApiSScivdsEJbgBiWjU+0/Fs9/d2CT7dRLiFUy++vjgroT6VL gdJq8V5oKVIc5X+7Y95wsABumUYdWAZp4x76HQ== X-Google-Smtp-Source: AGRyM1ummHcv4YmBzQF2UjMZlRgMn8EgYxyFbY/AxWBSezepPmZZ6gULxdnDc+jSowPTBq4nLYPRsyqBX5nG9adIf9Q= X-Received: by 2002:ac5:c916:0:b0:376:f130:808f with SMTP id t22-20020ac5c916000000b00376f130808fmr245211vkl.19.1659045038884; Thu, 28 Jul 2022 14:50:38 -0700 (PDT) MIME-Version: 1.0 References: <20220728185512.1270964-1-robh@kernel.org> In-Reply-To: <20220728185512.1270964-1-robh@kernel.org> From: Rob Herring Date: Thu, 28 Jul 2022 15:50:27 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: dma: arm,pl330: Add missing 'iommus' property To: Vinod Koul , Krzysztof Kozlowski Cc: "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 28, 2022 at 12:55 PM Rob Herring wrote: > > The pl330 can be behind an IOMMU which is the case for Arm Juno board. > Add the 'iommus' property allowing for 1 IOMMU per channel. > > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/dma/arm,pl330.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/arm,pl330.yaml b/Documentation/devicetree/bindings/dma/arm,pl330.yaml > index 2bec69b308f8..b9c4bee178ae 100644 > --- a/Documentation/devicetree/bindings/dma/arm,pl330.yaml > +++ b/Documentation/devicetree/bindings/dma/arm,pl330.yaml > @@ -55,6 +55,11 @@ properties: > > dma-coherent: true > > + iommus: > + minItems: 1 > + maxItems: 8 Off by 1. Juno has 9 entries. I think it's 8 entries for write the read side has 1 entry. The TRM isn't too clear. Rob > + description: Up to 1 IOMMU per DMA channel > + > power-domains: > maxItems: 1 > > -- > 2.34.1 >