From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Date: Tue, 14 Feb 2017 11:02:59 -0600 Message-ID: References: <1487063952-7113-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487063952-7113-4-git-send-email-chunyan.zhang@spreadtrum.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1487063952-7113-4-git-send-email-chunyan.zhang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chunyan Zhang Cc: Mark Rutland , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Arnd Bergmann , =?UTF-8?B?T3Jzb24gWmhhaSjnv5/kuqwp?= , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Feb 14, 2017 at 3:19 AM, Chunyan Zhang wrote: > This patch revise the compatible string of sprd uart to "sc-uart" > since this driver is not only for SC9836, but for all Spreadtrum > SoCs so far. > > Signed-off-by: Chunyan Zhang > --- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > index 2aff0f2..9b0ad52 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > @@ -1,7 +1,7 @@ > * Spreadtrum serial UART > > Required properties: > -- compatible: must be "sprd,sc9836-uart" > +- compatible: must be "sprd,sc-uart" You can't just change compatible strings. You don't need a generic-ish compatible if other SoCs have "the same" uart. Then you just do: '"sprd,sc-uart", "sprd,sc9836-uart"' in the DT. The existing driver will work matching on sprd,sc9836-uart and if you ever find some difference in the uarts you have the more specific compatible string to handle that. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html