From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "long.wanglong" <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
wanglong-m92B/FuLcaEcWVvVuXF20w@public.gmane.org
Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
Date: Sun, 26 Jul 2015 15:39:36 -0500 [thread overview]
Message-ID: <CAL_JsqKQ5y_iNezoTOty3ogC9Gmv4728Vf-BfoufN58u10vW7Q@mail.gmail.com> (raw)
In-Reply-To: <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
> On 2015/7/25 3:00, Rob Herring wrote:
>> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>>> Update the last pr_warning callsite in drivers/of.
>>
>> That is obvious in the diff, but can you tell me why?
>
> Hi Rob,
>
> When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
> will produce WARNING:
>
> WARNING: Prefer pr_warn(... to pr_warning(...
> #22: FILE: drivers/of/fdt.c:428:
> + pr_warning("End of tree marker overwritten: %08x\n",
>
> So,we should convert pr_warning to pr_warn.
Okay, but don't explain to me. Explain this in the commit message.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-26 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 8:01 [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn Wang Long
2015-07-24 19:00 ` Rob Herring
2015-07-25 0:57 ` long.wanglong
[not found] ` <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-07-26 20:39 ` Rob Herring [this message]
2015-07-27 1:47 ` long.wanglong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKQ5y_iNezoTOty3ogC9Gmv4728Vf-BfoufN58u10vW7Q@mail.gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wanglong-m92B/FuLcaEcWVvVuXF20w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).