From: Rob Herring <robherring2@gmail.com>
To: Suman Anna <s-anna@ti.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH] of: define of_find_node_by_phandle for !CONFIG_OF
Date: Tue, 23 Jun 2015 10:30:42 -0500 [thread overview]
Message-ID: <CAL_JsqKTnDXdgnKYhKcLnJ_PvEnM6HnU_N455cG6Wd_p2rrEag@mail.gmail.com> (raw)
In-Reply-To: <5582FEF4.3090708@ti.com>
On Thu, Jun 18, 2015 at 12:25 PM, Suman Anna <s-anna@ti.com> wrote:
> On 06/17/2015 06:33 PM, Rob Herring wrote:
>> On Wed, Jun 17, 2015 at 11:53 AM, Suman Anna <s-anna@ti.com> wrote:
>>> Define stub implementation for of_find_node_by_phandle() API
>>> so that users of this API can build properly even when CONFIG_OF
>>> is not defined.
>>>
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>
>> Do you have a user for this? If not, apply it when you do.
>
> Yeah, ran into a randconfig build problem on x86 when we tried to add an
> API to remoteproc core [1] that used this function.
Applied adding this info to the commit message. Thanks.
Rob
>
> regards
> Suman
>
> [1] http://marc.info/?l=devicetree&m=143232772426559&w=2
>
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>>
>>> ---
>>> include/linux/of.h | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/include/linux/of.h b/include/linux/of.h
>>> index ddeaae6d2083..90dfdc47ae26 100644
>>> --- a/include/linux/of.h
>>> +++ b/include/linux/of.h
>>> @@ -422,6 +422,11 @@ static inline struct device_node *of_find_node_opts_by_path(const char *path,
>>> return NULL;
>>> }
>>>
>>> +static inline struct device_node *of_find_node_by_phandle(phandle handle)
>>> +{
>>> + return NULL;
>>> +}
>>> +
>>> static inline struct device_node *of_get_parent(const struct device_node *node)
>>> {
>>> return NULL;
>>> --
>>> 2.4.1
>>>
>
prev parent reply other threads:[~2015-06-23 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 16:53 [PATCH] of: define of_find_node_by_phandle for !CONFIG_OF Suman Anna
2015-06-17 23:33 ` Rob Herring
2015-06-18 17:25 ` Suman Anna
2015-06-23 15:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKTnDXdgnKYhKcLnJ_PvEnM6HnU_N455cG6Wd_p2rrEag@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).