From: Rob Herring <robh+dt@kernel.org>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Matt Ranostay <mranostay@gmail.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Matt Ranostay <matt@ranostay.consulting>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] leds: leds-pca963x: add nxp,leds-suspend property
Date: Wed, 5 Oct 2016 07:22:58 -0500 [thread overview]
Message-ID: <CAL_JsqKVR9nHoAXcFVPBXp1io7_WCL6Jsrv=oJKGBopatL27sQ@mail.gmail.com> (raw)
In-Reply-To: <0ba8033f-d0b3-8b2f-8ff4-fa47dcf50ba1@samsung.com>
On Wed, Oct 5, 2016 at 3:09 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Hi Matt,
>
> On 10/05/2016 04:29 AM, Matt Ranostay wrote:
>>
>> Allow the LED subsystem to blank the LEDS on suspend.
>>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
>> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
>> ---
>> Documentation/devicetree/bindings/leds/pca963x.txt | 1 +
>> drivers/leds/leds-pca963x.c | 9 +++++++++
>> include/linux/platform_data/leds-pca963x.h | 6 ++++++
>> 3 files changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/pca963x.txt
>> b/Documentation/devicetree/bindings/leds/pca963x.txt
>> index dafbe9931c2b..61b1f037ebd0 100644
>> --- a/Documentation/devicetree/bindings/leds/pca963x.txt
>> +++ b/Documentation/devicetree/bindings/leds/pca963x.txt
>> @@ -7,6 +7,7 @@ Optional properties:
>> - nxp,totem-pole : use totem pole (push-pull) instead of open-drain
>> (pca9632 defaults
>> to open-drain, newer chips to totem pole)
>> - nxp,hw-blink : use hardware blinking instead of software blinking
>> +- nxp,leds-suspend : turn off LEDS on system suspend
>
>
> How about making this property generic and adding it to the common LED
> bindings?
>
> Cc Rob.
Fine with me though seems like keeping on would be less common. Maybe
"keep-in-suspend". Also, if this is a user decision, then it should be
a sysfs attr and shouldn't be in DT.
Rob
next prev parent reply other threads:[~2016-10-05 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161005022942eucas1p2b092723a0c38c116cc971971e43b169e@eucas1p2.samsung.com>
2016-10-05 2:29 ` [PATCH] leds: leds-pca963x: add nxp,leds-suspend property Matt Ranostay
2016-10-05 8:09 ` Jacek Anaszewski
2016-10-05 12:22 ` Rob Herring [this message]
2016-10-05 13:11 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKVR9nHoAXcFVPBXp1io7_WCL6Jsrv=oJKGBopatL27sQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=mranostay@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).