From: Rob Herring <robh+dt@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra <linux-tegra@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: memory-controller: Convert Tegra124 EMC to json-schema
Date: Mon, 13 Jan 2020 12:03:02 -0600 [thread overview]
Message-ID: <CAL_JsqKWRm7BN1vjV=DDHJooEbQti+zFN=PrvEtrNhKoKa06YQ@mail.gmail.com> (raw)
In-Reply-To: <20191222113921.1469372-2-thierry.reding@gmail.com>
On Sun, Dec 22, 2019 at 5:39 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the device tree bindings for the Tegra124 EMC controller to the
> DT schema format using json-schema. While at it, clean up the binding a
> little bit by removing any mention of how RAM code and clock frequency
> are represented in unit-addresses (which they aren't) and by adding the
> EMC clock without which the EMC controller can't change the frequency at
> which the external memory is clocked. While this is technically an ABI
> break (the clock was not required before), this should be fine because
> there isn't much that the EMC driver can do without access to the EMC
> clock.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../nvidia,tegra124-emc.txt | 374 -------------
> .../nvidia,tegra124-emc.yaml | 528 ++++++++++++++++++
> 2 files changed, 528 insertions(+), 374 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.txt
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml
The example fails 'make dt_binding_check':
/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.example.dt.yaml:
memory-controller@70019000: '#reset-cells' is a required property
/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.example.dt.yaml:
external-memory-controller@7001b000: emc-timings-0:timing-0:
'nvidia,emc-mrs-wait-cnt' is a required property
/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.example.dt.yaml:
external-memory-controller@7001b000: emc-timings-0:timing-0:
'nvidia,emc-xm2dqspadctrl2' is a required property
/home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.example.dt.yaml:
external-memory-controller@7001b000: emc-timings-0:timing-0:
'nvidia,emc-zcal-interval' is a required property
Rob
next prev parent reply other threads:[~2020-01-13 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 11:39 [PATCH 0/6] memory: tegra: Miscellaneous Tegra124 improvements Thierry Reding
2019-12-22 11:39 ` [PATCH 1/6] dt-bindings: memory-controller: Convert Tegra124 EMC to json-schema Thierry Reding
2020-01-08 15:35 ` Rob Herring
2020-01-13 18:03 ` Rob Herring [this message]
2019-12-22 11:39 ` [PATCH 2/6] memory: tegra: Refashion EMC debugfs interface on Tegra124 Thierry Reding
2019-12-22 11:39 ` [PATCH 3/6] ARM: tegra: Let the EMC hardware use the EMC clock Thierry Reding
2019-12-22 11:39 ` [PATCH 4/6] arm64: " Thierry Reding
2019-12-22 11:39 ` [PATCH 5/6] ARM: tegra: Rename EMC on Tegra124 Thierry Reding
2019-12-22 11:39 ` [PATCH 6/6] arm64: tegra: Rename EMC on Tegra132 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKWRm7BN1vjV=DDHJooEbQti+zFN=PrvEtrNhKoKa06YQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).