From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3C3C3F2D1 for ; Thu, 5 Mar 2020 15:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E47F2073D for ; Thu, 5 Mar 2020 15:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583422689; bh=pFOZLiv0mIVHTNZOWfiOPa3A/ridTd7fa+fuzsFhe40=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=F8p8NCie35q0ht7RPeskk1e54xx5fVL6Q4H698XNP8NN4HrznPKWGrbZfIwKMEs25 kSVdcVk4xZyDEWSeGgNkl37F/NojVM1jxkPjz7fU0rvyoYELnc9i471p1J5CeLnzkZ 5Rcmi0F4LLfQFKIY5OY1Z4vrykf7PLbqQeJ1XyaA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbgCEPiI (ORCPT ); Thu, 5 Mar 2020 10:38:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:59686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbgCEPiI (ORCPT ); Thu, 5 Mar 2020 10:38:08 -0500 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 219032073D; Thu, 5 Mar 2020 15:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583422687; bh=pFOZLiv0mIVHTNZOWfiOPa3A/ridTd7fa+fuzsFhe40=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=K44rhoDh34OpJhwV62dvPm3zfh+dqxbN7xwYVMhfZ6ZtnzxuPOWZhfpLyZuQqa7WQ NichaLzvxHrJDLkeBwtLMNXQRtD3/TVjiW+oqlRAriWQjYEti6aP1BLgLq7zNI2mxx 7X85qsau8d6izShQ8AZil0GgKS4OYGGK784FwZKk= Received: by mail-qt1-f176.google.com with SMTP id v22so4418939qtp.10; Thu, 05 Mar 2020 07:38:07 -0800 (PST) X-Gm-Message-State: ANhLgQ2FibSRIUifkvXSwNNXPqj3BiEkiU0K5UsMqj3iNdJIoZQzflF+ XnAF6ndI/ERNChGJMKgDxTS5X3oR3gg7Ko7M8w== X-Google-Smtp-Source: ADFU+vsQsV656cyzVfl1AIRiy+kSqBsXm03AeKkd3MEkLkSKnRjRFBKeqrqHktEL6J028OlhKaosK6M+LVN7lOLFI+w= X-Received: by 2002:ac8:7c9b:: with SMTP id y27mr7976141qtv.300.1583422686231; Thu, 05 Mar 2020 07:38:06 -0800 (PST) MIME-Version: 1.0 References: <59d24f8ec98e29d119c5cbdb2abe6d4644cc51cf.1582528977.git.amit.kucheria@linaro.org> <20200224184003.GA3607@bogus> In-Reply-To: From: Rob Herring Date: Thu, 5 Mar 2020 09:37:54 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v1 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones To: Amit Kucheria Cc: LKML , linux-arm-msm , Stephen Boyd , Matthias Kaehlcke , Daniel Lezcano , Zhang Rui , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 5, 2020 at 6:50 AM Amit Kucheria wrote: > > On Tue, Feb 25, 2020 at 12:10 AM Rob Herring wrote: > > > > On Mon, 24 Feb 2020 12:55:37 +0530, Amit Kucheria wrote: > > > As part of moving the thermal bindings to YAML, split it up into 3 > > > bindings: thermal sensors, cooling devices and thermal zones. > > > > > > The thermal-zone binding is a software abstraction to capture the > > > properties of each zone - how often they should be checked, the > > > temperature thresholds (trips) at which mitigation actions need to be > > > taken and the level of mitigation needed at those thresholds. > > > > > > Signed-off-by: Amit Kucheria > > > --- > > > .../bindings/thermal/thermal-zones.yaml | 302 ++++++++++++++++++ > > > 1 file changed, 302 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/thermal/thermal-zones.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > > This one isn't due to my patch, I believe. Right, that's the one known warning... > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c263000: interrupt-names: ['uplow'] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c263000: interrupts: [[0, 506, 4]] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c265000: interrupt-names: ['uplow'] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c265000: interrupts: [[0, 507, 4]] is too short > > Fixed. Just for my information, did the check somehow figure out that > this (incomplete) example needed the qcom-tsens.yaml binding (based on > compatible string?) and then apply those rules to throw this error? Yes. And setting DT_SCHEMA_FILES did change that to only check with the specified schema file. However, that's now changed in linux-next such that examples are always checked by all schemas and DT_SCHEMA_FILES just limits which bindings to build and check. Rob