From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec Date: Wed, 1 Aug 2018 16:20:20 -0600 Message-ID: References: <20180727121806.18209-1-srinivas.kandagatla@linaro.org> <20180727121806.18209-2-srinivas.kandagatla@linaro.org> <20180731204315.GA5265@rob-hp-laptop> <53a4e82c-7270-fdbd-a2ea-efbfc2d747a2@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53a4e82c-7270-fdbd-a2ea-efbfc2d747a2@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Srinivas Kandagatla Cc: Mark Rutland , devicetree@vger.kernel.org, Linux-ALSA , Banajit Goswami , "linux-kernel@vger.kernel.org" , Liam Girdwood , Takashi Iwai , Vinod , Mark Brown , Lee Jones List-Id: devicetree@vger.kernel.org On Wed, Aug 1, 2018 at 2:57 AM Srinivas Kandagatla wrote: > > Thanks for the review. > > On 31/07/18 21:43, Rob Herring wrote: > >> + > >> +- reset-gpio: > > reset-gpios > > > Yep, reset-gpios makes more inline with others! > >> + Usage: required > >> + Value type: > >> + Definition: Reset gpio line > >> + > >> +- qcom,ifd: > >> + Usage: required > >> + Value type: > >> + Definition: SLIM interface device > > Wouldn't this be the parent? > > > No, Interface device is just like other slim device and is part of > SLIMbus Component and has a unique address. Every SLIMbus component has > one interface device. I still don't understand what this means. If this is SLIMbus specific, then maybe it should be named that way? Or it is QCom specific? Rob