From: Rob Herring <robherring2@gmail.com>
To: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"chris@printf.net" <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andy Green <andy.green@linaro.org>,
Linaro Patches <patches@linaro.org>,
Jaswinder Singh <jaswinder.singh@linaro.org>,
Vincent Yang <Vincent.Yang@tw.fujitsu.com>,
Tetsuya Takinishi <t.takinishi@jp.fujitsu.com>
Subject: Re: [PATCH 6/9] mmc: sdhci: host: add new f_sdh30
Date: Thu, 20 Nov 2014 12:18:17 -0600 [thread overview]
Message-ID: <CAL_JsqKe_NA_mQ1MVMntXMjFGP6nGvnpWb8gvBEzRZuZ+aMf1g@mail.gmail.com> (raw)
In-Reply-To: <CAOEd-H0_YGHobKu08pMr3A4EpqBdtpBcCZu5PoVY_SZ=GBg-3w@mail.gmail.com>
On Thu, Nov 20, 2014 at 10:59 AM, Vincent Yang
<vincent.yang.fujitsu@gmail.com> wrote:
> 2014-11-20 23:22 GMT+08:00 Rob Herring <robherring2@gmail.com>:
>> On Thu, Nov 20, 2014 at 6:38 AM, Vincent Yang
>> <vincent.yang.fujitsu@gmail.com> wrote:
>>> This patch adds new host controller driver for
>>> Fujitsu SDHCI controller f_sdh30.
>>>
>>> Signed-off-by: Andy Green <andy.green@linaro.org>
>>> Signed-off-by: Vincent Yang <Vincent.Yang@tw.fujitsu.com>
>>> Signed-off-by: Tetsuya Takinishi <t.takinishi@jp.fujitsu.com>
>>> ---
>>> .../devicetree/bindings/mmc/sdhci-fujitsu.txt | 35 +++
>>> drivers/mmc/host/Kconfig | 9 +
>>> drivers/mmc/host/Makefile | 1 +
>>> drivers/mmc/host/sdhci_f_sdh30.c | 319 +++++++++++++++++++++
>>> 4 files changed, 364 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
>>> create mode 100644 drivers/mmc/host/sdhci_f_sdh30.c
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
>>> new file mode 100644
>>> index 0000000..a1e0b64
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
>>> @@ -0,0 +1,35 @@
>>> +* Fujitsu SDHCI controller
>>> +
>>> +This file documents differences between the core properties in mmc.txt
>>> +and the properties used by the sdhci_f_sdh30 driver.
>>> +
>>> +Required properties:
>>> +- compatible: "fujitsu,mb86s70-sdh30"
>>
>> It would be nice to have sdhci in the name to indicate it is an SDHCI
>> controller.
>
> Yes, we will update it to "fujitsu,sdhci-f-sdh30"
> Thanks for your review!
Not really what I had in mind as you are then dropping the chip name.
Perhaps "fujitsu,mb86s70-sdhci-3.0". Is 3.0 the SD spec version or IP
version? If the former, I think I'd drop it as IIRC that is available
in a register.
Rob
next prev parent reply other threads:[~2014-11-20 18:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 12:27 [PATCH 0/9] Support for Fujitsu MB86S7X SoCs Vincent Yang
2014-11-20 12:37 ` [PATCH 5/9] gpio: Add Fujitsu MB86S7x GPIO driver Vincent Yang
2014-11-27 7:33 ` Alexandre Courbot
2014-12-11 16:00 ` Jassi Brar
2014-12-03 13:32 ` Linus Walleij
2014-12-11 16:01 ` Jassi Brar
2014-11-20 12:38 ` [PATCH 6/9] mmc: sdhci: host: add new f_sdh30 Vincent Yang
2014-11-20 15:22 ` Rob Herring
2014-11-20 16:59 ` Vincent Yang
2014-11-20 18:18 ` Rob Herring [this message]
2014-11-21 1:18 ` Vincent Yang
[not found] ` <1416486442-25200-1-git-send-email-Vincent.Yang-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
2014-11-20 12:30 ` [PATCH 1/9] ARM: Add platform support for Fujitsu MB86S7X SoCs Vincent Yang
2014-11-20 12:34 ` [PATCH 2/9] mailbox: arm_mhu: add driver for ARM MHU controller Vincent Yang
[not found] ` <1416486872-25301-1-git-send-email-Vincent.Yang-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
2014-11-25 14:37 ` Sudeep Holla
[not found] ` <54749429.9080505-5wv7dgnIgG8@public.gmane.org>
2014-11-25 16:51 ` Jassi Brar
[not found] ` <CAJe_ZhciCP2VbmRtrq9d14WhfLhnC-xaitCCiW_6Yf1S-0sdUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-25 18:01 ` Sudeep Holla
[not found] ` <5474C3DD.5060706-5wv7dgnIgG8@public.gmane.org>
2014-11-26 5:37 ` Jassi Brar
2014-11-26 5:44 ` Andy Green
[not found] ` <CAJe_ZhfkcSv7oBfXdiW5=F0bZvv+9z3m90cXdy=O66VwZWCQnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-26 14:00 ` Sudeep Holla
[not found] ` <5475DD19.9000107-5wv7dgnIgG8@public.gmane.org>
2014-11-26 16:20 ` Jassi Brar
[not found] ` <CAJe_ZheKfEkdzcNE_5cpDg4qbYNLEJ=kKi+ScRf2=a8irAfnDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-26 16:38 ` Sudeep Holla
[not found] ` <547601EF.7070307-5wv7dgnIgG8@public.gmane.org>
2014-11-27 5:11 ` Jassi Brar
[not found] ` <CAJe_Zhdmup3DB5R3gufiveYtOOU+zrMQJVanQxbjSQ996=ZLXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-27 13:25 ` Sudeep Holla
2014-11-20 12:36 ` [PATCH 4/9] clk: Add clock driver for mb86s7x Vincent Yang
[not found] ` <1416486975-25385-1-git-send-email-Vincent.Yang-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
2014-11-21 13:03 ` Arnd Bergmann
2014-11-21 13:22 ` Jassi Brar
[not found] ` <CAJe_ZhcxHnoUeBUk3w=_xyk5oMAuena9RjDnyRvzLtV2=LpQxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 14:34 ` Arnd Bergmann
2014-11-21 16:36 ` Jassi Brar
[not found] ` <CAJe_Zhdg0tRx1SiACpCci3B2XaCxECGvkE7D=fne6vch4Bhk-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 17:15 ` Arnd Bergmann
2014-11-21 17:58 ` Jassi Brar
2014-11-21 20:12 ` Arnd Bergmann
2014-11-20 12:38 ` [PATCH 7/9] dt: mb86s7x: add dt files for MB86S7x evbs Vincent Yang
[not found] ` <1416487126-25509-1-git-send-email-Vincent.Yang-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
2014-11-21 14:26 ` Arnd Bergmann
2014-11-21 16:49 ` Jassi Brar
[not found] ` <CAJe_ZhfJBftYd7oYNqUsgZsVZS8ccRA5XngJ=msRnt7RSE+C2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 17:09 ` Arnd Bergmann
2014-11-21 17:35 ` Jassi Brar
2014-11-21 20:14 ` Arnd Bergmann
2014-11-20 12:39 ` [PATCH 8/9] of: add Fujitsu vendor prefix Vincent Yang
[not found] ` <1416487165-25551-1-git-send-email-Vincent.Yang-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
2014-11-20 15:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKe_NA_mQ1MVMntXMjFGP6nGvnpWb8gvBEzRZuZ+aMf1g@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=Vincent.Yang@tw.fujitsu.com \
--cc=andy.green@linaro.org \
--cc=arnd@arndb.de \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=t.takinishi@jp.fujitsu.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.yang.fujitsu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).