From: Rob Herring <robh@kernel.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree-owner@vger.kernel.org
Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150
Date: Tue, 11 Feb 2020 12:24:34 -0600 [thread overview]
Message-ID: <CAL_JsqKeytW=k5efjcfcuK6vbGggdO9nVdwq7YGNtMpzPQHWMg@mail.gmail.com> (raw)
In-Reply-To: <f26464226f74dffe2db0583b9482a489@codeaurora.org>
On Fri, Feb 7, 2020 at 12:10 AM Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Hi Rob,
>
> On 2020-02-07 00:08, Rob Herring wrote:
> > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote:
> >> Add missing compatible for watchdog timer on QCS404,
> >> SC7180, SDM845 and SM8150 SoCs.
> >
> > That's not what the commit does. You are changing what's valid.
> >
> > One string was valid, now 2 are required.
> >
>
> Does this look good?
No. First of all, what's the base for the diff? It's not what you
originally had nor incremental on top of this patch.
Second, a value of 'qcom,kpss-timer' or 'qcom,kpss-wdt' or
'qcom,scss-timer' will fail validation because 2 clauses of 'oneOf'
will be true.
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 46d6aad5786a..3378244b67cd 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -14,19 +14,22 @@ allOf:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - enum:
> - qcom,apss-wdt-qcs404
> - qcom,apss-wdt-sc7180
> - qcom,apss-wdt-sdm845
> - qcom,apss-wdt-sm8150
> - - qcom,kpss-timer
> - - qcom,kpss-wdt
> - qcom,kpss-wdt-apq8064
> - qcom,kpss-wdt-ipq4019
> - qcom,kpss-wdt-ipq8064
> - qcom,kpss-wdt-msm8960
> + - qcom,kpss-timer
> + - qcom,kpss-wdt
> - qcom,scss-timer
> + - const: qcom,kpss-timer
> + - const: qcom,kpss-wdt
> + - const: qcom,scss-timer
>
> reg:
> maxItems: 1
>
> Thanks,
> Sai
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member
> of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-02-11 18:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 15:29 [PATCHv2 0/2] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2020-02-01 15:29 ` [PATCHv2 1/2] dt-bindings: watchdog: " Sai Prakash Ranjan
2020-02-02 4:41 ` Stephen Boyd
2020-02-02 4:43 ` Stephen Boyd
2020-02-02 5:07 ` Sai Prakash Ranjan
2020-02-06 18:39 ` Rob Herring
2020-02-01 15:29 ` [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
2020-02-02 4:41 ` Stephen Boyd
2020-02-06 18:38 ` Rob Herring
2020-02-07 6:10 ` Sai Prakash Ranjan
2020-02-11 18:24 ` Rob Herring [this message]
2020-02-11 21:57 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKeytW=k5efjcfcuK6vbGggdO9nVdwq7YGNtMpzPQHWMg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree-owner@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mka@chromium.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).