From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165DFC3B187 for ; Tue, 11 Feb 2020 18:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFBEC206D6 for ; Tue, 11 Feb 2020 18:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581445491; bh=15RkB8/lsxkdGVyrfUT3PmibNwKSs3pakIPq9O2QKGA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=gE+IoaM9yui0c24gxmn3CjiCrtfwq93sx43eztY6OiKhHXb1sLlbn+KrFie5Qlebr X+nPDP5KdvUG4GbvaiWsmdx0TdgKelF7okwh24XxQ2FRBYrmubyYw2AgXFzsH/jiO4 74u5wvae5kkxQQ2JjtUwqVkTdZyLYDXJKfEMidSk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729791AbgBKSYr (ORCPT ); Tue, 11 Feb 2020 13:24:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:53262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729169AbgBKSYr (ORCPT ); Tue, 11 Feb 2020 13:24:47 -0500 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95D8F21569; Tue, 11 Feb 2020 18:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581445486; bh=15RkB8/lsxkdGVyrfUT3PmibNwKSs3pakIPq9O2QKGA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A8Zqm6fJP2FLzduLIBDokEhN/2d/UrH1tTPxjD5ihd4BFsmr4U+TmlhZKIyLl5OeE y8tyZK1Z+LwxdaT3JO7a63fwdEV45iurNjgynCzt3Az2dG8qrc/SS5bt9W9L6m3vm8 E4RlmQ+12GEi7n7znDshSniOcw1AMCbrmborQU5w= Received: by mail-qv1-f52.google.com with SMTP id m5so5451862qvv.4; Tue, 11 Feb 2020 10:24:46 -0800 (PST) X-Gm-Message-State: APjAAAVWVPt0aQfAjtZ+25pKee02DYuBkCsSHZvoTSb/5yltM791ECxQ DVFgRweIAJZ8wRqtiX/KlHfI0kJzeI87u4hfPw== X-Google-Smtp-Source: APXvYqxfEK6hEL7IX2KvoJP4sjzXqu7vc6OB5e1z94Q1gXnPXU2WIumcI1fS/UN5s1vfda4olh8aSlNY95DTbeSQkqo= X-Received: by 2002:a05:6214:11ac:: with SMTP id u12mr4114530qvv.85.1581445485691; Tue, 11 Feb 2020 10:24:45 -0800 (PST) MIME-Version: 1.0 References: <20200206183808.GA5019@bogus> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 12:24:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 To: Sai Prakash Ranjan Cc: Andy Gross , Bjorn Andersson , Guenter Roeck , devicetree@vger.kernel.org, Douglas Anderson , Stephen Boyd , Matthias Kaehlcke , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , linux-arm-msm , devicetree-owner@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 7, 2020 at 12:10 AM Sai Prakash Ranjan wrote: > > Hi Rob, > > On 2020-02-07 00:08, Rob Herring wrote: > > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: > >> Add missing compatible for watchdog timer on QCS404, > >> SC7180, SDM845 and SM8150 SoCs. > > > > That's not what the commit does. You are changing what's valid. > > > > One string was valid, now 2 are required. > > > > Does this look good? No. First of all, what's the base for the diff? It's not what you originally had nor incremental on top of this patch. Second, a value of 'qcom,kpss-timer' or 'qcom,kpss-wdt' or 'qcom,scss-timer' will fail validation because 2 clauses of 'oneOf' will be true. > > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > index 46d6aad5786a..3378244b67cd 100644 > --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > @@ -14,19 +14,22 @@ allOf: > > properties: > compatible: > - items: > + oneOf: > - enum: > - qcom,apss-wdt-qcs404 > - qcom,apss-wdt-sc7180 > - qcom,apss-wdt-sdm845 > - qcom,apss-wdt-sm8150 > - - qcom,kpss-timer > - - qcom,kpss-wdt > - qcom,kpss-wdt-apq8064 > - qcom,kpss-wdt-ipq4019 > - qcom,kpss-wdt-ipq8064 > - qcom,kpss-wdt-msm8960 > + - qcom,kpss-timer > + - qcom,kpss-wdt > - qcom,scss-timer > + - const: qcom,kpss-timer > + - const: qcom,kpss-wdt > + - const: qcom,scss-timer > > reg: > maxItems: 1 > > Thanks, > Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a > member > of Code Aurora Forum, hosted by The Linux Foundation