From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD71FC433DF for ; Mon, 13 Jul 2020 20:07:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B996E2075D for ; Mon, 13 Jul 2020 20:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594670855; bh=el2TSaA51OBPVLkDDeD8yCGwUzxK15hdRdqHbPo0Gd4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=jdwETZBVvZszA7ZwbK/gg4uPyFcWndy4ouhc5rKShl2ieBaoVbmTmnEq6XB2N6+3k 1mO+3wsry4TvrVGkjRRAZbG7ba/LG+ZVS4kw8us2KKPBhoRW22xZpCHctAf4Ad0wlh 4Pg42imh+n2BsKAsUmoD9ZWBNwO+BU7F6MxMyJos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbgGMUHf (ORCPT ); Mon, 13 Jul 2020 16:07:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726318AbgGMUHf (ORCPT ); Mon, 13 Jul 2020 16:07:35 -0400 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B71B20674; Mon, 13 Jul 2020 20:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594670854; bh=el2TSaA51OBPVLkDDeD8yCGwUzxK15hdRdqHbPo0Gd4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LXzVDn5pkKS0An517v/7JENO250tcmsnGlzb86UWhSRrfQCXjstLe17mYI7qOm5yu cgflia2veWjOVbMXxLZlCjgAb7PBslOGFJkeBXhlf9IyonWBxCFWW2p2Q20RwZJ77R yOLnMU99wX7+r2gzPKt5D/GGh+y/XDzxL9u6DiGc= Received: by mail-oi1-f172.google.com with SMTP id j11so12013356oiw.12; Mon, 13 Jul 2020 13:07:34 -0700 (PDT) X-Gm-Message-State: AOAM533sGX6ZzwVMVTRjFpl9iCvOPag3ljbhQxSYN9NBKGSO6U2qzHqr PVRid7sRat1Kyu0hGYz8oamsmAhij0kZJ07SQw== X-Google-Smtp-Source: ABdhPJzUtGDD0HwNcn/1+pNFN3WYRAm3lG5CxSfwC3x1ErEV4o5K6cU2yEixZOuco3cq9VWpgL8u6672rK/xNRyTSDQ= X-Received: by 2002:aca:30d2:: with SMTP id w201mr963673oiw.147.1594670853845; Mon, 13 Jul 2020 13:07:33 -0700 (PDT) MIME-Version: 1.0 References: <2774047.62mrzoXREp@tool> <20200713183635.GA503416@bogus> In-Reply-To: From: Rob Herring Date: Mon, 13 Jul 2020 14:07:22 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/2] dt-bindings: power: reset: add yaml bindings for LinkStation power off To: =?UTF-8?Q?Daniel_Gonz=C3=A1lez_Cabanelas?= Cc: "open list:THERMAL" , Sebastian Reichel , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 13, 2020 at 1:54 PM Daniel Gonz=C3=A1lez Cabanelas wrote: > > Hi Rob, > > El lun., 13 jul. 2020 a las 20:36, Rob Herring () escrib= i=C3=B3: > > > > On Sat, Jun 13, 2020 at 12:26:56PM +0200, Daniel Gonz=C3=A1lez Cabanela= s wrote: > > > Add Linkstation poweroff bindings documentation. > > > > > > Signed-off-by: Daniel Gonz=C3=A1lez Cabanelas > > > --- > > > Changes in v3: > > > - "phy-handle,intn" property deleted. Now autodetection used. > > > - Cosmetic changes > > > Changes in v2: > > > - Changed the required properties and description to adjust to the = new > > > driver now enabling the WoL feature on the device. > > > > > > .../power/reset/linkstation-poweroff.yaml | 35 +++++++++++++++++= ++ > > > 1 file changed, 35 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/power/reset/lin= kstation-poweroff.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/power/reset/linkstatio= n-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/linkstation= -poweroff.yaml > > > new file mode 100644 > > > index 0000000000..8845333ca4 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/power/reset/linkstation-power= off.yaml > > > @@ -0,0 +1,35 @@ > > > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) > > > > As I said before: > > > > GPL-2.0-only > Sorry, it was a copy paste error. > > > > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/power/reset/linkstation-poweroff.= yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Buffalo Linkstation poweroff Binding > > > + > > > +maintainers: > > > + - Daniel Gonz=C3=A1lez Cabanelas > > > + > > > +description: | > > > + Some Buffalo LinkStations (ARM MVEBU boards) use an output pin at = the ethernet > > > + PHY (LED2/INTn) to inform the board if the power off operation mus= t be performed > > > + at restart time. This pin is ORed with the power switch and allows= the WOL > > > + function to be also used. > > > + > > > + When the power-off handler is called, the ethernet PHY INTn ouptut= is set to > > > + LOW state. If the restart command is executed then the PHY INTn ou= tput is > > > + forced to HIGH state. > > > + > > > +properties: > > > + compatible: > > > + const: linkstation,power-off > > > + > > > +required: > > > + - compatible > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + poweroff { > > > + compatible =3D "linkstation,power-off"; > > > + }; > > > > This is not what I was suggesting in the last version. You don't need a > > binding for this. Use the root node compatible string. > > > Then I don't need any binding?, and therefore if I understood > correctly this patch isn't required. Right. > > Your driver initcall needs to check the root compatible and create a > > platform device if it matches. > > Are you suggesting to validate the driver only for one specific device? No, you can have a match table with as many entries as you need. > BTW the driver was already checked by Sebastian Reichel and nothing > wrong was found. > > Regards > Daniel > > > > > Rob