* [PATCH v2 0/4] PCI: brcmstb: Some minor fixes/features
@ 2020-05-01 14:28 Jim Quinlan
2020-05-01 14:28 ` [PATCH v2 3/4] dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s' Jim Quinlan
0 siblings, 1 reply; 3+ messages in thread
From: Jim Quinlan @ 2020-05-01 14:28 UTC (permalink / raw)
To: james.quinlan
Cc: Andrew Murray,
open list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Jeremy Linton,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list, open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
Lorenzo Pieralisi, Nicolas Saenz Julienne, Rob Herring
v2 -- Dropped commit concerning CRS.
-- Chanded new prop 'brcm,aspm-en-l0s' to 'aspm-no-l0s'.
-- Capitalize first letter in commit subject line; spelling.
v1 -- original
Jim Quinlan (4):
PCI: brcmstb: Don't clk_put() a managed clock
PCI: brcmstb: Fix window register offset from 4 to 8
dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s'
PCI: brcmstb: Disable L0s component of ASPM if requested
.../bindings/pci/brcm,stb-pcie.yaml | 4 ++++
drivers/pci/controller/pcie-brcmstb.c | 19 +++++++++++++++----
2 files changed, 19 insertions(+), 4 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 3/4] dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s'
2020-05-01 14:28 [PATCH v2 0/4] PCI: brcmstb: Some minor fixes/features Jim Quinlan
@ 2020-05-01 14:28 ` Jim Quinlan
2020-05-01 15:48 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Jim Quinlan @ 2020-05-01 14:28 UTC (permalink / raw)
To: james.quinlan
Cc: Jim Quinlan, Nicolas Saenz Julienne, Florian Fainelli,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Bjorn Helgaas,
Rob Herring,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:PCI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: Jim Quinlan <jquinlan@broadcom.com>
For various reasons, one may want to disable the ASPM L0s
capability.
Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
---
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 77d3e81a437b..084e4cf68b95 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -56,6 +56,10 @@ properties:
description: Indicates usage of spread-spectrum clocking.
type: boolean
+ aspm-no-l0s:
+ description: Disables ASPM L0s capability.
+ type: boolean
+
required:
- reg
- dma-ranges
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s'
2020-05-01 14:28 ` [PATCH v2 3/4] dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s' Jim Quinlan
@ 2020-05-01 15:48 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-05-01 15:48 UTC (permalink / raw)
To: Jim Quinlan
Cc: Nicolas Saenz Julienne, Florian Fainelli,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Bjorn Helgaas,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:PCI SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Fri, May 1, 2020 at 9:29 AM Jim Quinlan <james.quinlan@broadcom.com> wrote:
>
> From: Jim Quinlan <jquinlan@broadcom.com>
>
> For various reasons, one may want to disable the ASPM L0s
> capability.
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 77d3e81a437b..084e4cf68b95 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -56,6 +56,10 @@ properties:
> description: Indicates usage of spread-spectrum clocking.
> type: boolean
>
> + aspm-no-l0s:
> + description: Disables ASPM L0s capability.
> + type: boolean
Copied from rockchip-pcie-host.txt? Let's make this a standard
property. It should be documented here[1].
Then this doc just needs 'aspm-no-l0s: true' to indicate you are using it.
Rob
[1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/pci/pci-bus.yaml
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-01 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-01 14:28 [PATCH v2 0/4] PCI: brcmstb: Some minor fixes/features Jim Quinlan
2020-05-01 14:28 ` [PATCH v2 3/4] dt-bindings: PCI: brcmstb: New prop 'aspm-no-l0s' Jim Quinlan
2020-05-01 15:48 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).