From: Rob Herring <robh+dt@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: devicetree <devicetree@vger.kernel.org>
Subject: Re: audio-graph-port.yaml doesn't work ?
Date: Thu, 15 Jul 2021 12:12:41 -0600 [thread overview]
Message-ID: <CAL_JsqKoupwtgs8mDCKsQPS0+GRMQ9FjVAR=Cv+jpwRUKFdcfQ@mail.gmail.com> (raw)
In-Reply-To: <874kernyzk.wl-kuninori.morimoto.gx@renesas.com>
On Mon, May 24, 2021 at 11:50 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Rob
>
> I noticed that it seems "$ref: audio-graph-port.yaml#" is not working.
> For example, below is under "renesas,rcar.yaml" control which
> is using "$ref: audio-graph-port.yaml#" for ports/port and endpoint.
>
> "audio-graph-port.yaml" has "endpoint" properties,
> and below are not allowed by it.
> But there is no warning/error by
>
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
>
> Am I misunderstanding ?
Sorry, I missed this. Independently, with some meta-schema
improvements I think I found the issue:
ports:
$ref: /schemas/graph.yaml#/properties/ports
properties:
port(@[0-9a-f]+)?:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
The problem is you have a regex under 'properties' so it's treated as
a fixed string.
Will send out a patch shortly.
Rob
prev parent reply other threads:[~2021-07-15 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 5:50 audio-graph-port.yaml doesn't work ? Kuninori Morimoto
2021-07-15 18:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKoupwtgs8mDCKsQPS0+GRMQ9FjVAR=Cv+jpwRUKFdcfQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).