From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC/PATCH] drivers/of/platform: Add powerpc 4xx embedded busses to default list
Date: Tue, 5 Sep 2017 09:25:23 -0500 [thread overview]
Message-ID: <CAL_JsqKv-nU7Am=Jz+PFnmpiXWfwscHNFdb0KfYdROOHmTrSHg@mail.gmail.com> (raw)
In-Reply-To: <1504309672.4974.93.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
On Fri, Sep 1, 2017 at 6:47 PM, Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote:
> On Fri, 2017-09-01 at 10:24 -0500, Rob Herring wrote:
>> On Thu, Aug 31, 2017 at 10:51 PM, Benjamin Herrenschmidt
>> <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote:
>> > This allow to (slowly) migrate those embedded platforms
>> > to of_platform_default_populate()
>> >
>> > Signed-off-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
>> > ---
>> >
>> > I'm here to collect acks (or comments :-) I'd like this to go via
>> > the powerpc tree along with the patches converting some of the
>> > platforms. I'll be adding more bus types if/when I start tackling
>> > other powerpc embedded families but for now I'm dealing with 4xx.
>>
>> Glad to see it.
>
> So my end game is to remove the #ifndef CONFIG_PPC around
> of_platform_default_populate_init(void). However, for that
> to work, I need to add a way to disable that on some platforms.
>
> However, it might take time, especially when it comes to dealing
> with the old Macs or some more obscure embedded platforms.
>
> So in the meantime, I'm thinking adding some kind of runtime way
> of disabling this default populate. Would you be ok with that ?
>
> Something like:
>
> bool arch_wants_of_platform_defaults(void)
>
> With a weak implementation returning true.
That seems fine. The intention was that you can call
of_platform_default_populate multiple times with arch specific match
lists and the default. There could be ordering issues both with
initcall levels and device creation ordering.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-05 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 3:51 [RFC/PATCH] drivers/of/platform: Add powerpc 4xx embedded busses to default list Benjamin Herrenschmidt
[not found] ` <1504237861.4974.59.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-09-01 5:10 ` Greg Kroah-Hartman
2017-09-01 15:24 ` Rob Herring
[not found] ` <CAL_JsqLYMeV6XsBOtZKJHFbC2+_cG+gF7L+LurH5keTtzp2wVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-01 23:47 ` Benjamin Herrenschmidt
[not found] ` <1504309672.4974.93.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-09-05 14:25 ` Rob Herring [this message]
2017-09-05 22:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKv-nU7Am=Jz+PFnmpiXWfwscHNFdb0KfYdROOHmTrSHg@mail.gmail.com' \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).