Re: [PATCH v1 3/4] dt-bindings: pinctrl: add binding for MT7988 SoC

[Rob Herring <robh@kernel.org>]

On Sat, Oct 5, 2024 at 2:41 PM Frank Wunderlich <frank-w@public-files.de> wrote:
>
> Hi Rob
>
> Thank you for first review
>
> Am 5. Oktober 2024 20:44:49 MESZ schrieb Rob Herring <robh@kernel.org>:
> >On Fri, Oct 04, 2024 at 02:34:17PM +0200, Frank Wunderlich wrote:
>
> >> +patternProperties:
> >> +  '-pins$':
> >> +    type: object
> >> +    additionalProperties: false
> >> +
> >> +    patternProperties:
> >> +      '^.*mux.*$':
> >
> >Do you really need 'mux' anywhere in the name?
> >
> >> +        type: object
> >> +        additionalProperties: false
> >> +        description: |
> >> +          pinmux configuration nodes.
> ...
> >> +      '^.*conf.*$':
> >
> >Really need 'conf' anywhere in the name?
> >
> >> +        type: object
> >> +        additionalProperties: false
> >> +        description:
> >> +          pinconf configuration nodes.
> >> +        $ref: /schemas/pinctrl/pincfg-node.yaml
>
> mux and conf are used to match subnodes see example for mdio0_pins
>
> mdio0_pins: mdio0-pins {
>   mux {
>     function = "eth";
>     groups = "mdc_mdio0";
>   };
>
>   conf {
>     pins = "SMI_0_MDC", "SMI_0_MDIO";
>     drive-strength = <MTK_DRIVE_8mA>;
>   };
> };
>
> This is same as done for previous SoC like mt7986.

Why do you need foomuxbar? Please define a prefix or suffix (separated
by a '-') or just a fixed string.

Either we missed it on mt7986 or it was documenting something already in use.

Rob