From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Laurent <laurent.pinchart@ideasonboard.com>,
Guennadi <g.liakhovetski@gmx.de>,
Grant Likely <grant.likely@linaro.org>,
Frank Rowand <frowand.list@gmail.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Linux-DT <devicetree@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 0/7] of_graph: prepare for ALSA graph support
Date: Tue, 5 Jul 2016 11:38:38 -0500 [thread overview]
Message-ID: <CAL_JsqKvcNdxp27dvNUToKoDofLfqGVQvfaH-uwvDuepct3vfA@mail.gmail.com> (raw)
In-Reply-To: <87mvlw4nje.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jul 5, 2016 at 1:24 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Rob, Mark, again
>
>> Yes, as you pointed, sound side (= ALSA SoC) will use generic driver
>> for sound card which needs to know its total port number.
>> Then, these patches are needed.
>>
>> I posted OF graph part only this time, but of course I have total full-set
>> in my local environment.
>> But these are ...
>> 1) cleanup current generic sound driver (= almost 30 patch)
>> 2) OF graph new feature (= this patch-set) (= almost 10 patch)
>> 3) OF graph base generic sound driver (= almost 30 patch)
>> - ...
>>
>> I'm posting 1) part to ALSA SoC ML, 2) part to this ML.
>> 1) will take more long term >> Mark ??
>> If you want to see this patch-set together with use case, then 3) is needed.
>> If so, I will merge 2) and 3), and post these to this ML and ALSA SoC ML.
>>
>> Is it OK for you ? >> Rob, Mark
>> I don't know how to handle it, but I can follow your opinion
>
> I think we can use 2 patterns ?
>
> pattern1)
> post "OF graph new feature" patch and "ALSA SoC use it" patch
>
> 1. OF graph new feature 1 patch
> 2. ALSA SoC use feature 1 patch
> 3. OF graph new feature 2 patch
> 4. ALSA SoC use feature 2 patch
> 5. OF graph new feature 3 patch
> 6. ALSA SoC use feature 3 patch
> ...
>
> It is easy to review, but difficult on maintainer ?
>
> pattern2)
> post "OF graph new feature" patch-set and "ALSA SoC use it" patch-set
>
> 1. OF graph new feature 1 patch
> 2. OF graph new feature 2 patch
> 3. OF graph new feature 3 patch
> 4. ALSA SoC use feature 1 patch
> 5. ALSA SoC use feature 2 patch
> 6. ALSA SoC use feature 3 patch
> ...
>
> It is easy on maintainer, difficult to review ?
>
> Actually, this patch-set is 1, 2, 3 part of pattern2).
> I can post all patch-set in next time if we use pattern2) case.
>
> Or I can post as pattern1), and maintainer will pickup as
> pattern2) order ?
>
>> > In general, all these helpers look okay if you have a user for them.
>>
>> Thanks.
>> As I explained above, it is based on 1) part, but it will takes more
>> long term.
>>
next prev parent reply other threads:[~2016-07-05 16:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 0:33 [PATCH v2 0/7] of_graph: prepare for ALSA graph support Kuninori Morimoto
2016-06-29 0:34 ` [PATCH v2 1/7] Documentation: of: add type property Kuninori Morimoto
2016-06-29 0:35 ` [PATCH v2 2/7] of_graph: add of_graph_get_remote_endpoint() Kuninori Morimoto
2016-06-29 0:35 ` [PATCH v2 3/7] of_graph: add of_graph_port_type_is() Kuninori Morimoto
2016-06-29 0:35 ` [PATCH v2 4/7] of_graph: add of_graph_get_port_parent() Kuninori Morimoto
2016-06-29 0:36 ` [PATCH v2 5/7] of_graph: add of_graph_get_top_port() Kuninori Morimoto
[not found] ` <87k2h8g7rr.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-06-29 0:36 ` [PATCH v2 6/7] of_graph: add for_each_of_port() / for_each_of_endpoint_in_port() Kuninori Morimoto
2016-06-29 0:37 ` [PATCH v2 7/7] of_graph: add of_graph_get_endpoint_count() Kuninori Morimoto
2016-06-29 0:39 ` [PATCH v2 0/7] of_graph: prepare for ALSA graph support Mark Brown
[not found] ` <20160629003914.GG17217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-06-29 1:09 ` Kuninori Morimoto
2016-07-04 16:07 ` Rob Herring
2016-07-04 23:41 ` Kuninori Morimoto
2016-07-05 6:24 ` Kuninori Morimoto
2016-07-05 16:38 ` Rob Herring [this message]
2016-07-05 16:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKvcNdxp27dvNUToKoDofLfqGVQvfaH-uwvDuepct3vfA@mail.gmail.com \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=grant.likely@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).