From: Rob Herring <robh@kernel.org>
To: Rui Miguel Silva <rmfrfs@gmail.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/3] dt-bindings: imx7-mipi-csi2: convert bindings to yaml
Date: Wed, 21 Oct 2020 08:05:53 -0500 [thread overview]
Message-ID: <CAL_JsqKzvMj4WZz3N8wf=H8p3bZGo_vohWE9pdaSWwjxB5tDgQ@mail.gmail.com> (raw)
In-Reply-To: <20201020185206.qst2uksgcy3axbnh@arch-thunder.localdomain>
On Tue, Oct 20, 2020 at 1:52 PM Rui Miguel Silva <rmfrfs@gmail.com> wrote:
>
> Hi Rob Bot,
> On Tue, Oct 20, 2020 at 10:30:44AM -0500, Rob Herring wrote:
> > On Tue, 20 Oct 2020 10:19:21 +0100, Rui Miguel Silva wrote:
> > > Convert imx7 mipi csi2 bindings documentation to yaml schema, remove
> > > the textual document and update MAINTAINERS entry.
> > >
> > > Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
> > > ---
> > > .../bindings/media/imx7-mipi-csi2.txt | 90 ---------
> > > .../bindings/media/nxp,imx7-mipi-csi2.yaml | 172 ++++++++++++++++++
> > > MAINTAINERS | 2 +-
> > > 3 files changed, 173 insertions(+), 91 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt
> > > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> > >
> >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > ./Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml:91:21: [warning] wrong indentation: expected 22 but found 20 (indentation)
> > ./Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml:93:21: [warning] wrong indentation: expected 22 but found 20 (indentation)
>
> Strange not to complain on line 94 also.
>
> >
> >
> > See https://patchwork.ozlabs.org/patch/1384742
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> I have done this and I am at version:
> 2020.8.2.dev4+g341f3e35180a
>
> and still do not get any warning on this file. Nevertheless I
> found the indentation issue and will:
It's coming from yamllint which is recently added (this merge window)
and is optionally run if yamllint is present. Will clarify this in the
email.
Rob
next prev parent reply other threads:[~2020-10-21 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:19 [PATCH v4 0/3] dt-bindings: media: imx7 and ov2680 updates to yaml Rui Miguel Silva
2020-10-20 9:19 ` [PATCH v4 1/3] dt-bindings: ov2680: convert bindings " Rui Miguel Silva
2020-10-20 9:19 ` [PATCH v4 2/3] dt-bindings: imx7-csi: " Rui Miguel Silva
2020-10-20 9:19 ` [PATCH v4 3/3] dt-bindings: imx7-mipi-csi2: " Rui Miguel Silva
2020-10-20 15:30 ` Rob Herring
2020-10-20 18:52 ` Rui Miguel Silva
2020-10-21 13:05 ` Rob Herring [this message]
2020-10-21 20:51 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKzvMj4WZz3N8wf=H8p3bZGo_vohWE9pdaSWwjxB5tDgQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).