From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34DF74E1C0; Mon, 11 Dec 2023 17:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="siz1Izml" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2C71C433C8; Mon, 11 Dec 2023 17:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702316756; bh=O7wjFCJQlMWHBmegNZT1hxTWnkBth0ZVbCZUnv29/lw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=siz1Izml3pxtqg7z6WiQUs5+dXCMkv1u/VDIhoWyfA4LlmfO8X334fiSq4xlsydzW kgmseEhhpvnpyEudgGwmIgDWQRZ5m0i/280tEYjQbGTmV0wAgjlH9GnveMzhhnxen0 P4gxfzYlUJjbTGVTFB2BM8d2+3uvcQ8uoUsLRCR35eeE7SyZtl3h+4m6ZiFaXv9ZPM MYfOIlIznWeUlNcubiLjOgonzXjRhN5h+JS531Tu7mdGHwywfQ+GZ995nwaHNTp7Zf Y6jLp2JUq+tu/J/6RI2bNB752rH9PGqSILroGKdZ8q+66GCWDEQ0FhIKD0m10rsgGw 5ndum0w0LRS+A== Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2c9f099cf3aso71215661fa.1; Mon, 11 Dec 2023 09:45:56 -0800 (PST) X-Gm-Message-State: AOJu0Yxitm9euZwgLpT1HLyi3PkNWQ9wdpreiG53XOmgi5T0r7b2Al4P +2LmVhIs2f216C/fCV2A1Vz/Pf/aPl25RIh89w== X-Google-Smtp-Source: AGHT+IGAdABMDRq4vTTJBpK5U/6vD+zrpbpPPjjj1jukQ1ZAJnbCUkfAC9Da5KG1CLO16tfEBQkodtzt3t8iWp163mg= X-Received: by 2002:ac2:4d91:0:b0:50b:f87a:66a9 with SMTP id g17-20020ac24d91000000b0050bf87a66a9mr2390805lfe.110.1702316754903; Mon, 11 Dec 2023 09:45:54 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231206-icc-msm8909-v1-0-fe0dd632beff@kernkonzept.com> <20231206-icc-msm8909-v1-2-fe0dd632beff@kernkonzept.com> In-Reply-To: <20231206-icc-msm8909-v1-2-fe0dd632beff@kernkonzept.com> From: Rob Herring Date: Mon, 11 Dec 2023 11:45:42 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver To: Stephan Gerhold Cc: Georgi Djakov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Skladowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 6, 2023 at 8:35=E2=80=AFAM Stephan Gerhold wrote: > > From: Adam Skladowski > > Add driver for interconnect busses found in MSM8909 based platforms. > The topology consists of three NoCs that are partially controlled by a > RPM processor. > > In the downstream/vendor kernel from Qualcomm there is an additional > "mm-snoc". However, it doesn't have a separate RPM clock assigned. It > looks like this is actually the same NoC in hardware and the "mm-snoc" > was only defined to assign a different "qcom,util-fact". In mainline we > can represent this by assigning the equivalent "ab_coeff" to all the > nodes that are part of "mm-snoc" downstream. > > Signed-off-by: Adam Skladowski > [Stephan: Drop separate mm-snoc that exists downstream since it's > actually the same NoC as SNoC in hardware, add qos_offset for BIMC, > add ab_coeff for mm-snoc nodes and BIMC] > Signed-off-by: Stephan Gerhold > --- > drivers/interconnect/qcom/Kconfig | 9 + > drivers/interconnect/qcom/Makefile | 2 + > drivers/interconnect/qcom/msm8909.c | 1329 +++++++++++++++++++++++++++++= ++++++ > 3 files changed, 1340 insertions(+) > > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qco= m/Kconfig > index 4d15ce2dab16..ad03182b0587 100644 > --- a/drivers/interconnect/qcom/Kconfig > +++ b/drivers/interconnect/qcom/Kconfig > @@ -8,6 +8,15 @@ config INTERCONNECT_QCOM > config INTERCONNECT_QCOM_BCM_VOTER > tristate > > +config INTERCONNECT_QCOM_MSM8909 > + tristate "Qualcomm MSM8909 interconnect driver" > + depends on INTERCONNECT_QCOM > + depends on QCOM_SMD_RPM > + select INTERCONNECT_QCOM_SMD_RPM > + help > + This is a driver for the Qualcomm Network-on-Chip on msm8909-ba= sed > + platforms. > + > config INTERCONNECT_QCOM_MSM8916 > tristate "Qualcomm MSM8916 interconnect driver" > depends on INTERCONNECT_QCOM > diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qc= om/Makefile > index 3a8a6ef67543..69eaddccd4f1 100644 > --- a/drivers/interconnect/qcom/Makefile > +++ b/drivers/interconnect/qcom/Makefile > @@ -4,6 +4,7 @@ obj-$(CONFIG_INTERCONNECT_QCOM) +=3D interconnect_qcom.o > > interconnect_qcom-y :=3D icc-common.o > icc-bcm-voter-objs :=3D bcm-voter.o > +qnoc-msm8909-objs :=3D msm8909.o > qnoc-msm8916-objs :=3D msm8916.o > qnoc-msm8939-objs :=3D msm8939.o > qnoc-msm8974-objs :=3D msm8974.o > @@ -35,6 +36,7 @@ qnoc-x1e80100-objs :=3D x1e80100.o > icc-smd-rpm-objs :=3D smd-rpm.o icc-rpm.o icc-rpm-= clocks.o > > obj-$(CONFIG_INTERCONNECT_QCOM_BCM_VOTER) +=3D icc-bcm-voter.o > +obj-$(CONFIG_INTERCONNECT_QCOM_MSM8909) +=3D qnoc-msm8909.o > obj-$(CONFIG_INTERCONNECT_QCOM_MSM8916) +=3D qnoc-msm8916.o > obj-$(CONFIG_INTERCONNECT_QCOM_MSM8939) +=3D qnoc-msm8939.o > obj-$(CONFIG_INTERCONNECT_QCOM_MSM8974) +=3D qnoc-msm8974.o > diff --git a/drivers/interconnect/qcom/msm8909.c b/drivers/interconnect/q= com/msm8909.c > new file mode 100644 > index 000000000000..81335476aa51 > --- /dev/null > +++ b/drivers/interconnect/qcom/msm8909.c > @@ -0,0 +1,1329 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include You probably don't need these 2 headers and the implicit includes it makes are dropped now in linux-next. Please check what you actually need and make them explicit. Rob