Re: [PATCH v4 2/2] ASoc: Add devictree bindings for CS35L35 CODEC

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Mon, Jan 30, 2017 at 2:39 PM, Brian Austin <brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org> wrote:
> On Mon, 30 Jan 2017, Rob Herring wrote:
>
>> On Wed, Jan 25, 2017 at 10:13:18AM -0600, Brian Austin wrote:
>> > Add devicetree bindings documentatin for
>> > Cirrus Logic CS35L35 Boosted Amplifier
>> >
>> > Signed-off-by: Brian Austin <brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
>> > ---
>> >  .../devicetree/bindings/sound/cs35l35.txt          | 171 +++++++++++++++++++++
>> >  1 file changed, 171 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/sound/cs35l35.txt
>>
>> This looks similar to the CS35L33. Please align the property names and
>> perhaps combine into a single binding doc.
>>
>> Rob
>>
> I can make sure the names are consistent for some of them but most of it
> would be messy to combine into a single doc IMO. I know it looks similar
> for some of them like the algorithm nodes but they are very different in
> parameters and operation.
>
> Would it suffice to just make sure the properties that are the same be
> reflected across both docs?

That would be move in the right direction. Then we can see how
different they are.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html