From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCHv4 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec Date: Tue, 26 Dec 2017 17:05:27 -0600 Message-ID: References: <1514007876-16617-1-git-send-email-jassisinghbrar@gmail.com> <1514007911-16674-1-git-send-email-jassisinghbrar@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1514007911-16674-1-git-send-email-jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jassi Brar Cc: netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Miller , Arnd Bergmann , Andrew Lunn , Ard Biesheuvel , Mark Rutland , Masami Hiramatsu , Jassi Brar List-Id: devicetree@vger.kernel.org On Fri, Dec 22, 2017 at 11:45 PM, wrote: > From: Jassi Brar > > This patch adds documentation for Device-Tree bindings for the > Socionext NetSec Controller driver. > > Signed-off-by: Jassi Brar > Signed-off-by: Ard Biesheuvel > --- > .../devicetree/bindings/net/socionext-netsec.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/socionext-netsec.txt One other comment besides issues discussed on v2... > diff --git a/Documentation/devicetree/bindings/net/socionext-netsec.txt b/Documentation/devicetree/bindings/net/socionext-netsec.txt > new file mode 100644 > index 0000000..adc7bfa > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt > @@ -0,0 +1,55 @@ > +* Socionext NetSec Ethernet Controller IP > + > +Required properties: > +- compatible: Should be "socionext,synquacer-netsec" > +- reg: Address and length of the control register area, followed by the > + address and length of the EEPROM holding the MAC address and > + microengine firmware > +- interrupts: Should contain ethernet controller interrupt > +- clocks: phandle to the PHY reference clock, and any other clocks to be > + switched by runtime_pm > +- clock-names: Required only if more than a single clock is listed in 'clocks'. > + The PHY reference clock must be named 'phy_refclk' > +- phy-mode: See ethernet.txt file in the same directory > +- phy-handle: See ethernet.txt in the same directory. > + > +- mdio device tree subnode: When the Netsec has a phy connected to its local > + mdio, there must be device tree subnode with the following > + required properties: > + > + - #address-cells: Must be <1>. > + - #size-cells: Must be <0>. > + > + For each phy on the mdio bus, there must be a node with the following > + fields: > + - compatible: Refer to phy.txt > + - reg: phy id used to communicate to phy. > + > +Optional properties: (See ethernet.txt file in the same directory) > +- dma-coherent: Boolean property, must only be present if memory > + accesses performed by the device are cache coherent. > +- local-mac-address: See ethernet.txt in the same directory. > +- mac-address: See ethernet.txt in the same directory. > +- max-speed: See ethernet.txt in the same directory. > +- max-frame-size: See ethernet.txt in the same directory. > + > +Example: > + eth0: netsec@522d0000 { ethernet@... -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html