From: Rob Herring <robherring2@gmail.com>
To: Beomho Seo <beomho.seo@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
lee.jone@linaro.org, Mark Brown <broonie@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
dbaryshkov@gmail.com, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
InKi Dae <inki.dae@samsung.com>,
sw0312.kim@samsung.com, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH RESEND 3/3] Documentation: Add documentation for rt5033 multifunction device
Date: Tue, 6 Jan 2015 18:02:05 -0600 [thread overview]
Message-ID: <CAL_JsqL5UkxkX8hUHvQzFAT8JhGEj-eZLcmxJ4goUMo39_UOEA@mail.gmail.com> (raw)
In-Reply-To: <54AC7121.60303@samsung.com>
On Tue, Jan 6, 2015 at 5:34 PM, Beomho Seo <beomho.seo@samsung.com> wrote:
> Thank you for review.
>
> On 01/07/2015 01:54 AM, Rob Herring wrote:
>> On Mon, Jan 5, 2015 at 11:45 PM, Beomho Seo <beomho.seo@samsung.com> wrote:
>>> This patch device tree binding documentation for rt5033 multifunction device.
[...]
>>> + compatible = "i2c-gpio";
>>> + standard i2c-gpio constraints...
>>> + fuelgauge {
>>> + compatible = "richtek,rt5033-battery".
>>> + };
>>> + };
>>
>> I'm a bit confused by this. The fuelgauge is an i2c device hanging off
>> the rt5033 or a 2nd i2c slave on the rt5033?
>>
>
> It is 2nd i2c slave on the rt5033.
Okay, then you should leave out i2c-gpio from the example. The type of
i2c host is not relevant. You could for example have both slaves
attached to the same master. So just this (at the same level as
rt5033@34)
rt5033@35 {
compatible = "richtek,rt5033-battery";
interrupt-parent = <&gpx2>;
interrupts = <3 0>;
reg = <0x35>;
};
Rob
prev parent reply other threads:[~2015-01-07 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 5:45 [PATCH RESEND 0/3] power: rt5033: Add Richtek RT533 drivers Beomho Seo
2015-01-06 5:45 ` [PATCH RESEND 1/3] power: rt5033_battery: Add RT5033 Fuel gauge device driver Beomho Seo
2015-01-06 5:45 ` [PATCH RESEND 2/3] power: rt5033_charger: Add RT5033 charger " Beomho Seo
2015-01-06 5:45 ` [PATCH RESEND 3/3] Documentation: Add documentation for rt5033 multifunction device Beomho Seo
2015-01-06 16:54 ` Rob Herring
2015-01-06 23:34 ` Beomho Seo
2015-01-07 0:02 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqL5UkxkX8hUHvQzFAT8JhGEj-eZLcmxJ4goUMo39_UOEA@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=lee.jone@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).