From: Rob Herring <robh+dt@kernel.org>
To: Jacky Bai <ping.bai@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH 2/3] dt-bindings: arm: imx: Add the soc binding for imx8mm
Date: Mon, 4 Mar 2019 10:11:00 -0600 [thread overview]
Message-ID: <CAL_JsqLA+ypzHLC=mx2f5YJBs9EJooiOOqMKc-dnm3DW_GJXLw@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJFNgoAOHCOc0vdnxrwJR_T+iDddbS3nZc_d6grAC0k3w@mail.gmail.com>
On Mon, Mar 4, 2019 at 9:36 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Mar 4, 2019 at 3:12 AM Jacky Bai <ping.bai@nxp.com> wrote:
> >
> > Add the soc & board binding for i.MX8MM.
> >
> > Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 7e2cd6a..0620896 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -154,6 +154,12 @@ properties:
> > - const: compulab,cl-som-imx7
> > - const: fsl,imx7d
> >
> > + - description: i.MX8MM based Boards
> > + items:
>
> The indentation is wrong (and is significant). 'items' should be
> aligned with 'description'. IOW, it should be 6 spaces.
Looking again, items is correct, it is description that needs 2 more spaces.
Rob
next prev parent reply other threads:[~2019-03-04 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 9:12 [PATCH 1/3] arm64: dts: imx: Add i.mx8mm dtsi support Jacky Bai
2019-03-04 9:12 ` [PATCH 2/3] dt-bindings: arm: imx: Add the soc binding for imx8mm Jacky Bai
2019-03-04 15:36 ` Rob Herring
2019-03-04 16:11 ` Rob Herring [this message]
2019-03-05 1:43 ` Jacky Bai
2019-03-04 9:12 ` [PATCH 3/3] arm64: dts: imx: Add i.mx8mm evk basic dts support Jacky Bai
2019-03-04 11:45 ` Chris Spencer
2019-03-05 1:25 ` Jacky Bai
2019-03-04 9:42 ` [PATCH 1/3] arm64: dts: imx: Add i.mx8mm dtsi support Daniel Baluta
2019-03-04 9:46 ` Jacky Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLA+ypzHLC=mx2f5YJBs9EJooiOOqMKc-dnm3DW_GJXLw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).