From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/3] dt-bindings: arm: imx: Add the soc binding for imx8mm Date: Mon, 4 Mar 2019 10:11:00 -0600 Message-ID: References: <1551691021-31505-1-git-send-email-ping.bai@nxp.com> <1551691021-31505-2-git-send-email-ping.bai@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jacky Bai Cc: "mark.rutland@arm.com" , Aisheng Dong , "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" List-Id: devicetree@vger.kernel.org On Mon, Mar 4, 2019 at 9:36 AM Rob Herring wrote: > > On Mon, Mar 4, 2019 at 3:12 AM Jacky Bai wrote: > > > > Add the soc & board binding for i.MX8MM. > > > > Signed-off-by: Jacky Bai > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7e2cd6a..0620896 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -154,6 +154,12 @@ properties: > > - const: compulab,cl-som-imx7 > > - const: fsl,imx7d > > > > + - description: i.MX8MM based Boards > > + items: > > The indentation is wrong (and is significant). 'items' should be > aligned with 'description'. IOW, it should be 6 spaces. Looking again, items is correct, it is description that needs 2 more spaces. Rob