From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 01/10] of/irq: Rework of_irq_count() Date: Sun, 22 Sep 2013 16:19:27 -0500 Message-ID: References: <1379510692-32435-1-git-send-email-treding@nvidia.com> <1379510692-32435-2-git-send-email-treding@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1379510692-32435-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Rob Herring , Grant Likely , Greg Kroah-Hartman , Thomas Gleixner , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Russell King , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Benjamin Herrenschmidt , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ralf Baechle , sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Sep 18, 2013 at 8:24 AM, Thierry Reding wrote: > The of_irq_to_resource() helper that is used to implement of_irq_count() > tries to resolve interrupts and in fact creates a mapping for resolved > interrupts. That's pretty heavy lifting for something that claims to > just return the number of interrupts requested by a given device node. > > Instead, use the more lightweight of_irq_map_one(), which, despite the > name, doesn't create an actual mapping. Perhaps a better name would be > of_irq_translate_one(). > > Signed-off-by: Thierry Reding Acked-by: Rob Herring > --- > drivers/of/irq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index 1752988..5f44388 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -368,9 +368,10 @@ EXPORT_SYMBOL_GPL(of_irq_to_resource); > */ > int of_irq_count(struct device_node *dev) > { > + struct of_irq irq; > int nr = 0; > > - while (of_irq_to_resource(dev, nr, NULL)) > + while (of_irq_map_one(dev, nr, &irq) == 0) > nr++; > > return nr; > -- > 1.8.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html