From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF Date: Mon, 18 Sep 2017 16:28:04 -0500 Message-ID: References: <20170911200805.3363318-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170911200805.3363318-1-arnd-r2nGTMty4D4@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Andrew Morton , Frank Rowand , Bjorn Helgaas , Magnus Damm , Geert Uytterhoeven , Ben Dooks , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , SH-Linux , Sakari Ailus , Mika Westerberg , Geert Uytterhoeven , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, Sep 11, 2017 at 3:07 PM, Arnd Bergmann wrote: > The pci-rcar driver is enabled for compile tests, and this has > shown that the driver cannot build without CONFIG_OF, > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF > interrupt mapping when possible": > > drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init': > drivers/pci/host/pcie-rcar.c:1039:2: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration] > parser->pna = of_n_addr_cells(node); > ^ > As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually > supposed to build fine, which we can achieve if we make the > declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF > and provide an empty inline function otherwise, as we do for > a lot of other of interfaces. > > This lets us build the rcar_pci driver again without CONFIG_OF > for build testing. All platforms using this driver select OF, > so this doesn't change anything for the users. Sorry, I keep missing this. It's a flaw in my mail filtering... There's a patch series[1] to factor out pci_dma_range_parser_init of the driver which should also fix this. I'd prefer not to take this because ideally all address parsing should be within the DT core code. Rob [1] https://patchwork.kernel.org/patch/9927541/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html