From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC v1 3/7] iommu/arm-smmu-v3: Replace the device tree binding for hisilicon broken prefetch cmd with erratum id Date: Mon, 15 May 2017 10:23:51 -0500 Message-ID: References: <20170513094731.3676-1-shameerali.kolothum.thodi@huawei.com> <20170513094731.3676-4-shameerali.kolothum.thodi@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170513094731.3676-4-shameerali.kolothum.thodi@huawei.com> Sender: linux-acpi-owner@vger.kernel.org To: shameer Cc: Will Deacon , Robin Murphy , Mark Rutland , Lorenzo Pieralisi , Hanjun Guo , Gabriele Paoloni , John Garry , Linux IOMMU , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , devel@acpica.org, Linuxarm , "Wangzhou (B)" , Hanjun Guo List-Id: devicetree@vger.kernel.org On Sat, May 13, 2017 at 4:47 AM, shameer wrote: > Signed-off-by: shameer > --- > Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt > index be57550..bf48e92 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt > @@ -46,7 +46,7 @@ the PCIe specification. > devicetree/bindings/interrupt-controller/msi.txt > for a description of the msi-parent property. > > -- hisilicon,broken-prefetch-cmd > +- hisilicon,erratum-161010701 Why? Your missing commit msg should answer that. This breaks compatibility, so you are stuck with the old string. I'd prefer that you start using the compatible string rather than every vendor adding a property for every errata. Rob