* [PATCH] drivers/of: Export phandle iterators
@ 2016-11-23 19:06 Robin Murphy
[not found] ` <a1fa1157cab10f2a6f319d431d355cef79b91820.1479927866.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Robin Murphy @ 2016-11-23 19:06 UTC (permalink / raw)
To: devicetree, linux-kernel; +Cc: Rob Herring, Frank Rowand
Modular drivers may want to use of_for_each_phandle() - export its
constituent functions.
CC: Rob Herring <robh+dt@kernel.org>
CC: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
drivers/of/base.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index a0bccb54a9bd..92e35fe0189a 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1563,6 +1563,7 @@ int of_phandle_iterator_init(struct of_phandle_iterator *it,
return 0;
}
+EXPORT_SYMBOL_GPL(of_phandle_iterator_init);
int of_phandle_iterator_next(struct of_phandle_iterator *it)
{
@@ -1632,6 +1633,7 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
return -EINVAL;
}
+EXPORT_SYMBOL_GPL(of_phandle_iterator_next);
int of_phandle_iterator_args(struct of_phandle_iterator *it,
uint32_t *args,
@@ -1649,6 +1651,7 @@ int of_phandle_iterator_args(struct of_phandle_iterator *it,
return count;
}
+EXPORT_SYMBOL_GPL(of_phandle_iterator_args);
static int __of_parse_phandle_with_args(const struct device_node *np,
const char *list_name,
--
2.10.2.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <a1fa1157cab10f2a6f319d431d355cef79b91820.1479927866.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] drivers/of: Export phandle iterators [not found] ` <a1fa1157cab10f2a6f319d431d355cef79b91820.1479927866.git.robin.murphy-5wv7dgnIgG8@public.gmane.org> @ 2016-11-23 21:49 ` Rob Herring 2016-11-24 12:33 ` Robin Murphy 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2016-11-23 21:49 UTC (permalink / raw) To: Robin Murphy Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frank Rowand On Wed, Nov 23, 2016 at 1:06 PM, Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> wrote: > Modular drivers may want to use of_for_each_phandle() - export its > constituent functions. Do you have a user? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/of: Export phandle iterators 2016-11-23 21:49 ` Rob Herring @ 2016-11-24 12:33 ` Robin Murphy 2016-11-29 15:06 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Robin Murphy @ 2016-11-24 12:33 UTC (permalink / raw) To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand Hi Rob, On 23/11/16 21:49, Rob Herring wrote: > On Wed, Nov 23, 2016 at 1:06 PM, Robin Murphy <robin.murphy@arm.com> wrote: >> Modular drivers may want to use of_for_each_phandle() - export its >> constituent functions. > > Do you have a user? I've been experimenting with modular IOMMU drivers on top of the probe-deferral stuff[1], and the ARM SMMU driver in particular demands a whole pile of exports. I thought I'd throw this one out now since nearly all the other of_* functions are exported already, but I'm quite happy to sit on it if you'd prefer to wait for a concrete in-tree need (it'll be a while yet). Robin. [1]:http://www.linux-arm.org/git?p=linux-rm.git;a=shortlog;h=refs/heads/iommu/defer ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/of: Export phandle iterators 2016-11-24 12:33 ` Robin Murphy @ 2016-11-29 15:06 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2016-11-29 15:06 UTC (permalink / raw) To: Robin Murphy Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand On Thu, Nov 24, 2016 at 6:33 AM, Robin Murphy <robin.murphy@arm.com> wrote: > Hi Rob, > > On 23/11/16 21:49, Rob Herring wrote: >> On Wed, Nov 23, 2016 at 1:06 PM, Robin Murphy <robin.murphy@arm.com> wrote: >>> Modular drivers may want to use of_for_each_phandle() - export its >>> constituent functions. >> >> Do you have a user? > > I've been experimenting with modular IOMMU drivers on top of the > probe-deferral stuff[1], and the ARM SMMU driver in particular demands a > whole pile of exports. I thought I'd throw this one out now since nearly > all the other of_* functions are exported already, but I'm quite happy > to sit on it if you'd prefer to wait for a concrete in-tree need (it'll > be a while yet). > > Robin. > > [1]:http://www.linux-arm.org/git?p=linux-rm.git;a=shortlog;h=refs/heads/iommu/defer ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-29 15:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 19:06 [PATCH] drivers/of: Export phandle iterators Robin Murphy
[not found] ` <a1fa1157cab10f2a6f319d431d355cef79b91820.1479927866.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-11-23 21:49 ` Rob Herring
2016-11-24 12:33 ` Robin Murphy
2016-11-29 15:06 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).