From: Rob Herring <robh@kernel.org>
To: "Shenhar, Talel" <talel@amazon.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
David Miller <davem@davemloft.net>,
Shawn Lin <shawn.lin@rock-chips.com>,
Thomas Gleixner <tglx@linutronix.de>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dwmw@amazon.co.uk,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
jonnyc@amazon.com, hhhawa@amazon.com, ronenk@amazon.com,
hanochu@amazon.com, barakw@amazon.com
Subject: Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC
Date: Tue, 9 Jul 2019 07:25:33 -0600 [thread overview]
Message-ID: <CAL_JsqLNWAw2LtCvnsDkrUTmk-Vy1ncwR4XuCN7=_Sg8vbTr2w@mail.gmail.com> (raw)
In-Reply-To: <f1fd393d-0b8c-16f1-9ac2-0589e9cb9ea7@amazon.com>
On Tue, Jul 9, 2019 at 12:00 AM Shenhar, Talel <talel@amazon.com> wrote:
>
> Marc, should I publish those fixes as new patch that updates the
> dt-bindings or new patchset to this list?
>
> On 7/9/2019 5:23 AM, Rob Herring wrote:
> > On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote:
> >> +- #interrupt-cells: must be 2.
> >> + First cell defines the index of the interrupt within the controller.
> >> + Second cell is used to specify the trigger type and must be one of the
> >> + following:
> >> + - bits[3:0] trigger type and level flags
> >> + 1 = low-to-high edge triggered
> >> + 4 = active high level-sensitive
> > No need to define this here. Reference the standard definition.
>
> This device only support those two modes.
>
> This definition tries to capture the supported modes.
>
> Should I just state that those two modes are supported and then avoid
> the actual bits and values?
Yes.
Rob
next prev parent reply other threads:[~2019-07-09 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 8:34 [PATCH v4 0/2] Amazon's Annapurna Labs Fabric Interrupt Controller Talel Shenhar
2019-06-10 8:34 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC Talel Shenhar
2019-06-18 10:46 ` Marc Zyngier
2019-07-09 2:23 ` Rob Herring
2019-07-09 5:59 ` Shenhar, Talel
2019-07-09 8:15 ` Marc Zyngier
2019-07-09 8:17 ` Shenhar, Talel
2019-07-09 13:25 ` Rob Herring [this message]
2019-06-10 8:34 ` [PATCH v4 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Talel Shenhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLNWAw2LtCvnsDkrUTmk-Vy1ncwR4XuCN7=_Sg8vbTr2w@mail.gmail.com' \
--to=robh@kernel.org \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jason@lakedaemon.net \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=ronenk@amazon.com \
--cc=shawn.lin@rock-chips.com \
--cc=talel@amazon.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).