From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2488BC64E8A for ; Mon, 30 Nov 2020 14:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B70DD20684 for ; Mon, 30 Nov 2020 14:33:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XAxwCCne" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727057AbgK3Odc (ORCPT ); Mon, 30 Nov 2020 09:33:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:44070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbgK3Odb (ORCPT ); Mon, 30 Nov 2020 09:33:31 -0500 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7276320709; Mon, 30 Nov 2020 14:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606746770; bh=SuE4P++qmGoLIF8j33uj/kt53nUU2XUBIpidjDdUDcQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XAxwCCneycEo0STLrtMaQhdKZ0vIy3KX2+qKn8bxFx6V2pJKlDfCwdebLr9GFYJyL 16lHebPujB7w6CV7vLOdcAwlEwmV3Ey2hf6UPW2xxW2DgOhsFtgMgpm43mDRnQaJt8 mMzqeX9x7yi9OmkfOAPTltp96mvfQNpFA7OdHBYc= Received: by mail-ed1-f51.google.com with SMTP id d18so16372194edt.7; Mon, 30 Nov 2020 06:32:50 -0800 (PST) X-Gm-Message-State: AOAM530iVvwA0MFastt48Ias9c6F4ON4ZdYrS90tZ8G4ic2Hwk0M+IMH SMzYK5gZQQavkQS3WkEyMWdeVcNWQH9Ke3eDsw== X-Google-Smtp-Source: ABdhPJyTqjub2riyWhCOMyYIHeNVbIUSCia+ywmWQkoDk3lUZp34191pq9pG8Twi1LTvGpKxnvfe+omAGM3pVlOvnig= X-Received: by 2002:a50:c091:: with SMTP id k17mr1349767edf.137.1606746768862; Mon, 30 Nov 2020 06:32:48 -0800 (PST) MIME-Version: 1.0 References: <20201101093150.8071-1-paul@crapouillou.net> <20201101093150.8071-3-paul@crapouillou.net> <20201101122900.GB1269759@ravnborg.org> <9CZ5JQ.CWYPSJ8EDOW4@crapouillou.net> In-Reply-To: <9CZ5JQ.CWYPSJ8EDOW4@crapouillou.net> From: Rob Herring Date: Mon, 30 Nov 2020 07:32:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings To: Paul Cercueil , Sam Ravnborg Cc: Thierry Reding , Christophe Branchereau , od@zcrc.me, dri-devel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil wrote: > > > > Le dim. 1 nov. 2020 =C3=A0 13:29, Sam Ravnborg a =C3= =A9crit : > > On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote: > >> The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" 320x480 > >> 24-bit IPS LCD panel. Its particularity is that it has non-square > >> pixels > >> (as it is 4:3 for a resolution of 320x480), and that it requires odd > >> lines to be sent as RGB and even lines to be sent as GRB on its > >> 8-bit > >> bus. > >> > >> Signed-off-by: Paul Cercueil > >> --- > >> .../display/panel/abt,y030xx067a.yaml | 54 > >> +++++++++++++++++++ > >> 1 file changed, 54 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > >> new file mode 100644 > >> index 000000000000..6407e8bf45fa > >> --- /dev/null > >> +++ > >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml > >> @@ -0,0 +1,54 @@ > >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: > >> http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS LCD > >> panel > >> + > >> +description: | > >> + The panel must obey the rules for a SPI slave device as > >> specified in > >> + spi/spi-controller.yaml > >> + > >> +maintainers: > >> + - Paul Cercueil > >> + > >> +allOf: > >> + - $ref: panel-common.yaml# > >> + > >> +properties: > >> + compatible: > >> + const: abt,y030xx067a > >> + > >> + backlight: true > >> + port: true > >> + power-supply: true > >> + reg: true > >> + reset-gpios: true > > > > The binding is missing: > > required: > > - compatible > > - reg > > - power-supply > > - reset-gpios > > - ... > > > > additionalProperties: false > > > > So r-b only with these added. > > Stupid mistake, sorry about that. > > I'll V2. I don't have any V2 in my inbox, but looks like it is in linux-next now: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/disp= lay/panel/abt,y030xx067a.example.dt.yaml: panel@0: 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-bindings/Documentation/devicetree= /bindings/display/panel/abt,y030xx067a.yaml