From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/4] soc: qcom: add an EBI2 device tree bindings Date: Mon, 29 Aug 2016 17:51:14 -0500 Message-ID: References: <1470691445-27571-1-git-send-email-linus.walleij@linaro.org> <2988918.zNxvaGl6en@wuerfel> <201608291351.12915.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org To: Linus Walleij Cc: Arnd Bergmann , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, Andy Gross , David Brown , Stephen Boyd , "devicetree@vger.kernel.org" , Bjorn Andersson List-Id: devicetree@vger.kernel.org On Mon, Aug 29, 2016 at 12:21 PM, Linus Walleij wrote: > On Mon, Aug 29, 2016 at 4:06 PM, Rob Herring wrote: >> [Me] >>> That is very close to how >>> Documentation/devicetree/bindings/bus/imx-weim.txt >>> drivers/bus/imx-weim.c >>> does things, just with the additional property arrays. >> >> Maybe so, but I'm trying to bring some consistency here, so I'd >> suggest looking at newer ones like atmel IIRC. > > The Uniphier bindings also look like this and it's the most recent > bus driver ... > Documentation/devicetree/bindings/bus/uniphier-system-bus.txt > > But OK it's probably best to follow an example so I get it the way > you prefer. Which binding and driver is that? > > There's no Atmel stuff in Documentation/devicetree/bindings/bus/ > nor drivers/bus from what I can tell, so just point out what you're > referring to here and I'll do my best to follow that example. Argg, that's because it is in a different spot: Documentation/devicetree/bindings/memory-controllers/atmel,ebi.txt Time to clean things up... bindings/bus is supposed to be internal, on-chip buses. Rob