From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39806EE4993 for ; Mon, 21 Aug 2023 14:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235896AbjHUOX2 (ORCPT ); Mon, 21 Aug 2023 10:23:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235894AbjHUOX1 (ORCPT ); Mon, 21 Aug 2023 10:23:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D301E7; Mon, 21 Aug 2023 07:23:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2490E639A4; Mon, 21 Aug 2023 14:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86E60C433C9; Mon, 21 Aug 2023 14:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692627804; bh=OaWNqSvQEiD1xmCg4SPCQRjx+fMWtx5iLMEQKBnd8cw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rwhlq4tC4EvRUmr/wbT0Ue51oVpNlMsu83qtdLFrxL3InwKNRZ9fv9Q1CT7yhYQUq 2n1NzCWETXNLMkaMpID1GNQcgdbYEnMOfU3D94e3DYOBJhwhpBJYSVRAaHVNTKsEh8 pMea45h+BUy5LQJGwAL+M/2vdzp2jW77Ebp55DzJmZ4OdgErQ0WbH6A60lOrqWZp3g Nuo7DXXHAQD7aty3rQ+/oLuDvvBMPUadlGTtJQoA1gZHjy13VFq5oXUm+WPMrWyZ91 7y2jsova6Uz0AJlK9FAzH/WsUGhzHFwqcZqKJyDobBESaB2g3eiSj6cJYVK7XRuQqn 8ygIBIfSdlkdw== Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2bcb89b476bso22164741fa.1; Mon, 21 Aug 2023 07:23:24 -0700 (PDT) X-Gm-Message-State: AOJu0YwomV6JvOJwE1Sj++0x8wrqifA6Hn0z6K1MyI0lX4qq7QJA7a31 CWN9RQnxQarNrUzPk0DtoFWHXzkx226Yvtqocw== X-Google-Smtp-Source: AGHT+IGqWIjI4t81zqE/7ga2ouKLVTQbXY0MKa0xbyIPjA5d60S4eHI9X7anlOsfqpBvu7tnpqhcRmdxmQ2XPK6mec0= X-Received: by 2002:a2e:9d96:0:b0:2b6:c2e4:a57a with SMTP id c22-20020a2e9d96000000b002b6c2e4a57amr5393041ljj.38.1692627802545; Mon, 21 Aug 2023 07:23:22 -0700 (PDT) MIME-Version: 1.0 References: <20230801-dt-changeset-fixes-v3-0-5f0410e007dd@kernel.org> <20230801-dt-changeset-fixes-v3-5-5f0410e007dd@kernel.org> In-Reply-To: From: Rob Herring Date: Mon, 21 Aug 2023 09:23:10 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] of: dynamic: Move dead property list check into property add/update functions To: Geert Uytterhoeven Cc: Frank Rowand , "Enrico Weigelt, metux IT consult" , "Rafael J. Wysocki" , Sakari Ailus , Petr Mladek , Andy Shevchenko , Geert Uytterhoeven , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 21, 2023 at 8:05=E2=80=AFAM Geert Uytterhoeven wrote: > > Hi Rob, > > Thanks for your patch! > > > On Fri, Aug 18, 2023 at 10:41=E2=80=AFPM Rob Herring wr= ote: > > The changeset code checks for a property in the deadprops list when > > adding/updating a property, but of_add_property() and > > of_update_property() do not. As the users of these functions are pretty > > simple, they have not hit this scenario or else the property lists > > would get corrupted. > > > > With this there are 3 cases of removing a property from either deadprop= s > > or properties lists, so add a helper to find and remove a matching > > property. > > > > Signed-off-by: Rob Herring > > Reviewed-by: Geert Uytterhoeven Thanks! > > Perhaps this needs a Fixes tag? I didn't simply because in the decades that these functions existed, no one cared. It would require a specific sequence of calls which we could pretty much determine doesn't happen just looking at the callers in the kernel. Rob