From: Rob Herring <robherring2@gmail.com>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Kukjin Kim <kgene.kim@samsung.com>,
"Mark Brown (broonie@opensource.wolfsonmicro.com)"
<broonie@opensource.wolfsonmicro.com>,
kwangwoo.lee@gmail.com, jacmet@sunsite.dk,
augulis.darius@gmail.com, mcuelenaere@gmail.com,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v5 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs
Date: Wed, 17 Apr 2013 12:46:43 -0500 [thread overview]
Message-ID: <CAL_JsqL_i-5SDCsGZCrsxMehLVMGoLO1s_V3R-H6Oa5ff16dEQ@mail.gmail.com> (raw)
In-Reply-To: <1829212.6niSeTsyIU@amdc1227>
On Tue, Apr 16, 2013 at 8:19 AM, Tomasz Figa <t.figa@samsung.com> wrote:
> On Tuesday 16 of April 2013 08:09:10 Rob Herring wrote:
>> On 04/15/2013 04:14 PM, Tomasz Figa wrote:
>> > This patch adds basic device tree definitions for Samsung S3C64xx SoCs.
>> >
>> > Since all the SoCs in the series are very similar, the files are created
>> > hierarchically - one file for the whole series and then separate files
>> > for particular SoCs including the common one.
>> >
>> > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
>> > ---
>> >
>> > arch/arm/boot/dts/s3c6400.dtsi | 33 ++
>> > arch/arm/boot/dts/s3c6410.dtsi | 33 ++
>> > arch/arm/boot/dts/s3c64xx-pinctrl.dtsi | 683
>> > +++++++++++++++++++++++++++++++++ arch/arm/boot/dts/s3c64xx.dtsi
>> > | 136 +++++++
>> > 4 files changed, 885 insertions(+)
>> > create mode 100644 arch/arm/boot/dts/s3c6400.dtsi
>> > create mode 100644 arch/arm/boot/dts/s3c6410.dtsi
>> > create mode 100644 arch/arm/boot/dts/s3c64xx-pinctrl.dtsi
>> > create mode 100644 arch/arm/boot/dts/s3c64xx.dtsi
>>
>> [...]
>>
>> > +
>> > + vic0: interrupt-controller@71200000 {
>>
>> These nodes should be off a "simple-bus" node.
>
> Hmm, is there any reason behind it?
>
> I thought simple bus was just a convenient helper to represent hierarchical
> bus structures if one has a need to do so.
No. The DT should reflect the bus structure of the chip. How
accurately it is done is up to you and the information available, but
you have to have a bus of some sort.
There's obvious examples that don't follow this, but I'd like to not have more.
Rob
next prev parent reply other threads:[~2013-04-17 17:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 21:14 [PATCH v5 0/6] Initial Device Tree support for S3C64xx Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 1/6] ARM: common: vic: Parse interrupt and resume masks from device tree Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 2/6] ARM: s3c64xx: Skip legacy EINT setup if pinctrl-s3c64xx driver is present Tomasz Figa
2013-04-16 16:26 ` Mark Brown
2013-04-16 22:31 ` Tomasz Figa
2013-04-16 22:43 ` [PATCH v6 " Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 3/6] gpio: samsung: Skip legacy GPIO registration if pinctrl-s3c64xx " Tomasz Figa
2013-04-16 16:27 ` Mark Brown
2013-04-16 22:35 ` Tomasz Figa
2013-04-17 13:06 ` Mark Brown
2013-04-23 14:33 ` Kukjin Kim
2013-04-15 21:14 ` [PATCH v5 4/6] ARM: s3c64xx: Add board file for boot using Device Tree Tomasz Figa
2013-04-15 21:14 ` [PATCH v5 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs Tomasz Figa
2013-04-16 13:09 ` Rob Herring
2013-04-16 13:19 ` Tomasz Figa
2013-04-17 17:46 ` Rob Herring [this message]
2013-04-23 14:29 ` Kukjin Kim
2013-04-23 14:44 ` Tomasz Figa
2013-04-23 14:48 ` Kukjin Kim
2013-04-15 21:14 ` [PATCH v5 6/6] ARM: dts: Add dts file for S3C6410-based Mini6410 board Tomasz Figa
2013-04-16 16:33 ` [PATCH v5 0/6] Initial Device Tree support for S3C64xx Mark Brown
2013-04-16 22:23 ` [PATCH 1/2] pinctrl: s3c64xx: Fix build error caused by undefined chained_irq_enter Tomasz Figa
2013-04-16 22:24 ` [PATCH 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS disabled Tomasz Figa
2013-04-23 12:03 ` Linus Walleij
2013-04-23 12:09 ` Tomasz Figa
2013-04-24 14:27 ` Linus Walleij
2013-04-24 14:47 ` Tomasz Figa
2013-04-25 13:26 ` Linus Walleij
2013-04-16 22:29 ` [PATCH RESEND " Tomasz Figa
2013-04-23 12:00 ` [PATCH 1/2] pinctrl: s3c64xx: Fix build error caused by undefined chained_irq_enter Linus Walleij
2013-04-17 13:08 ` [PATCH v5 0/6] Initial Device Tree support for S3C64xx Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqL_i-5SDCsGZCrsxMehLVMGoLO1s_V3R-H6Oa5ff16dEQ@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=augulis.darius@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jacmet@sunsite.dk \
--cc=kgene.kim@samsung.com \
--cc=kwangwoo.lee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcuelenaere@gmail.com \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).