From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A2CC433FE for ; Fri, 18 Nov 2022 21:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbiKRVqH (ORCPT ); Fri, 18 Nov 2022 16:46:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbiKRVqG (ORCPT ); Fri, 18 Nov 2022 16:46:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E59C65E58; Fri, 18 Nov 2022 13:46:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19A4062798; Fri, 18 Nov 2022 21:46:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F2ECC43470; Fri, 18 Nov 2022 21:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668807964; bh=RNBGyT8pOapfGmKmgkwMpgie8elalZGmmgERqozynsA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PMorCDQIGJ64l2Kqj3yXz+JZWMspa46YvciYFDwUiWbmVAGPwa63kOqwfs+MpBvq+ 3FmCyGXkMptzQm+Wb3NQrjkH/ffkrqp6QSSK6LLVEdBZ7dYuXHks82Nw7cj8ZlarPM FUmht1b2FmkX+myZzfjf0o+bVip8Y8f1pypP/V/0dui7hHR+ONuPfHvQf7/mhLqfLQ U8mgnOud2jNBdYwwnYUmHdm+kQTvD3Wp7OBqwRjFPl/yt4EcPphXJZtUkS4FE9iH1G lMGDQgS9Cj9fLNqq5ZSu2WZBW2Avbnrf0H7iI1916iMQrq5v0RD/i3NaS/2Df7RZWj /ySe9OFXuw4IQ== Received: by mail-lf1-f44.google.com with SMTP id c1so10299825lfi.7; Fri, 18 Nov 2022 13:46:04 -0800 (PST) X-Gm-Message-State: ANoB5pk+fWTSz0DWYS480uiMm0i8zaYthDb0kdYncgPLOLtjytf1EW3O H+rnfiKO5RbjryU/qNCy9cJM7kvSv1NktJaEtw== X-Google-Smtp-Source: AA0mqf450V8MLhrSk+aZ9ENb/BJGi+0rLQx57RrQjhp4T28QJaf+DVYt15IhGTYuJbXF1stCgsvLBKHTzVMBV+osv2w= X-Received: by 2002:a05:6512:1291:b0:4af:eabf:3c57 with SMTP id u17-20020a056512129100b004afeabf3c57mr2788378lfs.449.1668807962519; Fri, 18 Nov 2022 13:46:02 -0800 (PST) MIME-Version: 1.0 References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> In-Reply-To: From: Rob Herring Date: Fri, 18 Nov 2022 15:45:54 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays To: Frank Wunderlich Cc: linux-mediatek@lists.infradead.org, Frank Wunderlich , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Nov 18, 2022 at 3:39 PM Rob Herring wrote: > > On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: > > > > From: Frank Wunderlich > > > > Add devicetree overlays for using nand and nor on BPI-R3. > > Can you not tell at runtime which one you booted from? If not, how > does one choose which overlay to apply? If you can, why not populate > both nodes and enable the right one? IMO, if all h/w is present, it > should all be in the DT. Selecting what h/w to use is a separate > problem and overlays aren't a great solution for that. > > > > Signed-off-by: Frank Wunderlich > > --- > > maybe rename to dtso? > > > > "kbuild: Allow DTB overlays to built from .dtso named source files" > > https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 > > > > more comments about the dt overlay-support: > > > > https://patchwork.kernel.org/comment/25092116/ > > https://patchwork.kernel.org/comment/25085681/ > > --- > > v4: > > - drop compile-comment from overlays > > - add author-information to dt-overlays > > --- > > arch/arm64/boot/dts/mediatek/Makefile | 2 + > > .../mediatek/mt7986a-bananapi-bpi-r3-nand.dts | 55 +++++++++++++++ > > .../mediatek/mt7986a-bananapi-bpi-r3-nor.dts | 69 +++++++++++++++++++ > > 3 files changed, 126 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dts > > > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > > index e8902f2cc58f..d42208c4090d 100644 > > --- a/arch/arm64/boot/dts/mediatek/Makefile > > +++ b/arch/arm64/boot/dts/mediatek/Makefile > > @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo > > These need rules to apply them to the base dtb(s). You just need: > > full.dtb := base.dtb overlay.dtb Oops, that should be: full-dtbs := base.dtb overlay.dtb dtb-y += full.dtb Just like multiple objs in a module. Rob