Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature

[Rob Herring <robh@kernel.org>]

On Mon, Aug 15, 2016 at 1:50 AM, Dongpo Li <lidongpo@hisilicon.com> wrote:
> Hi Rob,
> Many thanks for your review.
>
> On 2016/8/13 2:43, Rob Herring wrote:
>> On Thu, Aug 11, 2016 at 05:01:52PM +0800, Dongpo Li wrote:
>>> From: Li Dongpo <lidongpo@hisilicon.com>
>>>
>>> The "hix5hd2" is SoC name, add the generic ethernet driver name.
>>> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds
>>> the SG/TXCSUM/TSO/UFO features.
>>> This patch only adds the SG(scatter-gather) driver for transmitting,
>>> the drivers of other features will be submitted later.
>>
>> The compatible string changes should probably be a separate patch.
>>
> ok, I will split this patch into two patches, one for compatible string changes,
> and one for driver feature implementation.
>
>>> Signed-off-by: Dongpo Li <lidongpo@hisilicon.com>
>>> ---
>>>  .../bindings/net/hisilicon-hix5hd2-gmac.txt        |   9 +-
>>>  drivers/net/ethernet/hisilicon/hix5hd2_gmac.c      | 213 +++++++++++++++++++--
>>>  2 files changed, 205 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>>> index 75d398b..3c02fac 100644
>>> --- a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>>> @@ -1,7 +1,12 @@
>>>  Hisilicon hix5hd2 gmac controller
>>>
>>>  Required properties:
>>> -- compatible: should be "hisilicon,hix5hd2-gmac".
>>> +- compatible: should contain one of the following version strings:
>>> +    * "hisilicon,hisi-gemac-v1"
>>> +    * "hisilicon,hisi-gemac-v2"
>>> +    and one of the following SoC string:
>>> +    * "hisilicon,hix5hd2-gemac"
>>> +    * "hisilicon,hi3798cv200-gemac"
>>
>> Make it clear what the order should be.
>>
> ok, I will put the SoC strings in alphabetical order.

No, I mean the most specific string comes first.

Rob