From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F339C2D0DB for ; Fri, 31 Jan 2020 16:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46B30206F0 for ; Fri, 31 Jan 2020 16:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580489023; bh=dcG8NLMUHRnjiTnnFkv7SM8FQTdo7P01F6ozQIzzroY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QXTPcuXuxEk8KV07N9x55mt7TZqa2aAIaAmIZ22RK1ERvxDmwwDC5BRg/REFvLsnv KUE4Rzomji5h/hnCT2NfMVrXM3rIsgMvvZa5e9q/Nep3oYsvT7Sy6OD+8FLbtEHTNw C8xntGxqsEvF1AwcbacXtEawpk1vy3NTeiUK05PI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgAaQnj (ORCPT ); Fri, 31 Jan 2020 11:43:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:33398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbgAaQnj (ORCPT ); Fri, 31 Jan 2020 11:43:39 -0500 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 139242082E; Fri, 31 Jan 2020 16:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580489018; bh=dcG8NLMUHRnjiTnnFkv7SM8FQTdo7P01F6ozQIzzroY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XBNpfievlG4NIexK/B5BVWR7d1MGF+OlKAifaYr1ZU8Y9TOxykWDdPhMQggLXzE2i m5RmoOEFgDSp2lgqKI4Lpfn3jnWb3uPIFJNtBZ0whtL8QXHR4qjZ6Aq0VkPc/FTion 7BIU1RZ6hUXNmnGxFDW6TC9sxf4KnZZrayysm3+o= Received: by mail-qt1-f170.google.com with SMTP id h12so5911007qtu.1; Fri, 31 Jan 2020 08:43:38 -0800 (PST) X-Gm-Message-State: APjAAAX9QFjJktmMN09l9JPpoCPl0w543IWT/xX86mQ0QjCrzpi/Uh0D iBe2kx3jt1G4hDRGJAnRT8NNIYKiUPUQWlz9oA== X-Google-Smtp-Source: APXvYqwCAPGiNXBSYn6EM/ra6iIgv+Org4yFgElqW19yZ4ehMloqYiN9lT1FOFl8JlJVA/yMDf4WZx8drnrxynECj9Y= X-Received: by 2002:ac8:6747:: with SMTP id n7mr11498995qtp.224.1580489017216; Fri, 31 Jan 2020 08:43:37 -0800 (PST) MIME-Version: 1.0 References: <20200130211231.224656-1-dianders@chromium.org> <20200130131220.v3.7.I513cd73b16665065ae6c22cf594d8b543745e28c@changeid> In-Reply-To: <20200130131220.v3.7.I513cd73b16665065ae6c22cf594d8b543745e28c@changeid> From: Rob Herring Date: Fri, 31 Jan 2020 10:43:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 07/15] dt-bindings: clock: Fix qcom,gpucc bindings for sdm845/sc7180/msm8998 To: Douglas Anderson Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Jeffrey Hugo , Taniya Das , Jeffrey Hugo , linux-arm-msm , Harigovindan P , devicetree@vger.kernel.org, Matthias Kaehlcke , Kalyan Thota , Mark Rutland , linux-clk , "Kristian H. Kristensen" , Michael Turquette , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jan 30, 2020 at 3:12 PM Douglas Anderson wrote: > > The qcom,gpucc bindings had a few problems with them: > > 1. When things were converted to yaml the name of the "gpll0 main" > clock got changed from "gpll0" to "gpll0_main". Change it back for > msm8998. > > 2. Apparently there is a push not to use purist aliases for clocks but > instead to just use the internal Qualcomm names. For sdm845 and > sc7180 (where the drivers haven't already been changed) move in > this direction. > > Things were also getting complicated harder to deal with by jamming > several SoCs into one file. Splitting simplifies things. > > Fixes: 5c6f3a36b913 ("dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings") > Signed-off-by: Douglas Anderson > --- > > Changes in v3: > - Added pointer to inlude file in description. > - Everyone but msm8998 now uses internal QC names. > - Fixed typo grpahics => graphics > - Split bindings into 3 files. > > Changes in v2: > - Patch ("dt-bindings: clock: Fix qcom,gpucc...") new for v2. > > .../devicetree/bindings/clock/qcom,gpucc.yaml | 72 ------------------- > .../bindings/clock/qcom,msm8998-gpucc.yaml | 66 +++++++++++++++++ > .../bindings/clock/qcom,sc7180-gpucc.yaml | 72 +++++++++++++++++++ > .../bindings/clock/qcom,sdm845-gpucc.yaml | 72 +++++++++++++++++++ > 4 files changed, 210 insertions(+), 72 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/qcom,gpucc.yaml > create mode 100644 Documentation/devicetree/bindings/clock/qcom,msm8998-gpucc.yaml > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sdm845-gpucc.yaml I'm not seeing any differences in sdm845 and sc7180. Do those really need to be separate? It doesn't have to be all combined or all separate. Rob