From: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Linux-ALSA <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>,
Simon <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Linux-DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [resend][PATCH v5 07/10] ASoC: add snd_soc_get_dai_id()
Date: Mon, 17 Apr 2017 08:41:31 -0500 [thread overview]
Message-ID: <CAL_JsqLm6tcupSuvsd_yjVH6Ks+cEm1_p2WBToGLpQQFGVwfhA@mail.gmail.com> (raw)
In-Reply-To: <871ssrvqbk.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
On Sun, Apr 16, 2017 at 7:23 PM, Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>
> ALSA SoC needs to know connected DAI ID for probing.
> On OF-graph case, basically we can check DT port location.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> v4 -> v5
>
> - no change
You can keep posting the same version again, but I still have the same
objections.
Having the core graph-card parsing details of remote endpoints is
fragile. The driver for the remote node should do the parsing of its
own endpoints and is the only entity that should care or know what the
port and endpoint numbering is. The fact that you are planning to
change this for HDMI support is evidence of that. I don't see the
point of a temporary solution.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-17 13:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 0:20 [resend][PATCH v5 00/10] ASoC: add OF-graph base simple-card Kuninori Morimoto
[not found] ` <87bmrvvqgs.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-17 0:21 ` [resend][PATCH v5 01/10] of_graph: export symbol of_phandle_iterator_init/next Kuninori Morimoto
[not found] ` <87a87fvqfc.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-17 13:43 ` Rob Herring
[not found] ` <CAL_JsqJSN88P2D8sbWimxTjc=mUPBV4H7hfLzHCLmzZbOcZzQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-18 0:05 ` Kuninori Morimoto
2017-04-18 0:06 ` Rob Herring
2017-04-17 0:21 ` [resend][PATCH v5 02/10] of_graph: add of_graph_get_remote_endpoint() Kuninori Morimoto
2017-04-17 0:22 ` [resend][PATCH v5 03/10] of_graph: add of_graph_get_port_parent() Kuninori Morimoto
2017-04-17 0:22 ` [resend][PATCH v5 04/10] of_graph: add of_graph_get_endpoint_count() Kuninori Morimoto
2017-04-17 0:22 ` [resend][PATCH v5 05/10] ASoC: simple-card-utils: enable "label" on asoc_simple_card_parse_card_name Kuninori Morimoto
[not found] ` <874lxnvqcm.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-17 13:21 ` Rob Herring
[not found] ` <CAL_JsqKPJ6WF08hEtx2Y7Z5WqUXQ0OBOeohEaPujX891ksZS2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-17 23:58 ` Kuninori Morimoto
2017-04-17 0:23 ` [resend][PATCH v5 06/10] ASoC: soc-core: enable "dai-name" on snd_soc_of_parse_daifmt() Kuninori Morimoto
[not found] ` <8737d7vqc4.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-17 13:23 ` Rob Herring
[not found] ` <CAL_JsqLVM1mQWXv42N_hC+nTWV=dOaSc2wmu4SAAN3-w4O8v6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-18 0:00 ` Kuninori Morimoto
[not found] ` <8737d6zizt.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-18 0:05 ` Rob Herring
[not found] ` <CAL_Jsq+D9FsL=JG+ZCm4H8VAh=fSOAJcN_30UZC36vgX8n9Dng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-18 0:37 ` Kuninori Morimoto
2017-04-17 0:23 ` [resend][PATCH v5 07/10] ASoC: add snd_soc_get_dai_id() Kuninori Morimoto
[not found] ` <871ssrvqbk.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-17 13:41 ` Rob Herring [this message]
[not found] ` <CAL_JsqLm6tcupSuvsd_yjVH6Ks+cEm1_p2WBToGLpQQFGVwfhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-18 0:04 ` Kuninori Morimoto
2017-04-17 0:23 ` [resend][PATCH v5 08/10] ASoC: simple-card-utils: add asoc_simple_card_parse_graph_dai() Kuninori Morimoto
2017-04-17 0:23 ` [resend][PATCH v5 09/10] ASoC: add audio-graph-card document Kuninori Morimoto
2017-04-17 0:24 ` [resend][PATCH v5 10/10] ASoC: add audio-graph-card support Kuninori Morimoto
-- strict thread matches above, loose matches on Subject: below --
2017-04-03 8:10 [resend][PATCH v5 00/10] ASoC: add OF-graph base simple-card Kuninori Morimoto
[not found] ` <87vaqlnceg.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-04-03 8:14 ` [resend][PATCH v5 07/10] ASoC: add snd_soc_get_dai_id() Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLm6tcupSuvsd_yjVH6Ks+cEm1_p2WBToGLpQQFGVwfhA@mail.gmail.com \
--to=robh+dt-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).