of_irq_init() stopped working in 3.2-rc3

of_irq_init() stopped working in 3.2-rc3

[Pawel Moll]

Hi Rob,

Because your dc9372808412edbc653a675a526c2ee6c0c14a91 "of/irq:
of_irq_find_parent: check for parent equal to child" got reverted in
3.2-rc3, the of_irq_init() doesn't work, as...

8<----------------------------------------------------------
void __init of_irq_init(const struct of_device_id *matches)
{
        struct device_node *np, *parent = NULL;
[...]
                desc->interrupt_parent = of_irq_find_parent(np);
[...]
                /*
                 * Process all controllers with the current 'parent'.
                 * First pass will be looking for NULL as the parent.
                 * The assumption is that NULL parent means a root controller.
                 */
                list_for_each_entry_safe(desc, temp_desc, &intc_desc_list, list) {
[...]
                        if (desc->interrupt_parent != parent)
                                continue;
8<------------------------------------------------------------

... the desc->interrupt_parent is not NULL for the root interrupt controller
any more...

I've temporarily worked the problem around by re-applying the
of_irq_find_parent() change.

Cheers!

Paweł


_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: of_irq_init() stopped working in 3.2-rc3

[Rob Herring]

[-- Attachment #1.1: Type: text/plain, Size: 581 bytes --]

On Nov 25, 2011 12:08 PM, "Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org> wrote:
>
> Hi Rob,
>
> Because your dc9372808412edbc653a675a526c2ee6c0c14a91 "of/irq:
> of_irq_find_parent: check for parent equal to child" got reverted in
> 3.2-rc3, the of_irq_init() doesn't work, as...
>

Snip...

> ... the desc->interrupt_parent is not NULL for the root interrupt
controller
> any more...
>
> I've temporarily worked the problem around by re-applying the
> of_irq_find_parent() change.
>
You can also add "interrupt-parent;" to your gic DT node. I plan to send a
fix soon.

Rob

[-- Attachment #1.2: Type: text/html, Size: 815 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss