From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver Date: Tue, 25 Sep 2018 14:39:28 -0500 Message-ID: References: <20180911170825.17789-1-dmurphy@ti.com> <20180911170825.17789-4-dmurphy@ti.com> <20180924161844.GA29028@bogus> <20180924180219.GA24418@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180924180219.GA24418@amd> Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek Cc: Dan Murphy , Jacek Anaszewski , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Lee Jones , linux-omap , Linux LED Subsystem List-Id: devicetree@vger.kernel.org On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek wrote: > > Hi! > > > > Add the device tree bindings for the lm3697 > > > LED driver for backlighting and display. > > > > > > Signed-off-by: Dan Murphy > > > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++ > > > 1 file changed, 86 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt > > > > Reviewed-by: Rob Herring > > We already have binding for lm3697 in > Documentation/devicetree/bindings/mfd/ti-lmu.txt . Is it good idea to > have second one? Of course not. Now that you mention it, I do remember seeing some discussion on this. Rob